Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TODO: Handle dill binary object format in RocketSummary class #28

Closed
coderabbitai bot opened this issue Sep 11, 2024 · 0 comments · Fixed by #34
Closed

Resolve TODO: Handle dill binary object format in RocketSummary class #28

coderabbitai bot opened this issue Sep 11, 2024 · 0 comments · Fixed by #34
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

The TODO comment in the RocketSummary class (located in lib/views/rocket.py) mentions that the use of Any bypasses pydantic parsing and expects a dill binary object. This could lead to issues with data validation if not handled correctly. The expected data format should be properly handled to ensure compatibility with pydantic and avoid potential parsing issues.

Please address this TODO and ensure that the expected dill binary object format is correctly integrated into the class.

PR: #25
Comment: #25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant