-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Simulation Save and Load in JSON Files #695
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/sim-encoding #695 +/- ##
====================================================
+ Coverage 76.37% 76.38% +0.01%
====================================================
Files 94 94
Lines 11343 11341 -2
====================================================
Hits 8663 8663
+ Misses 2680 2678 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@phmbressan , as previously discussed, can you leave only one of the #679 and #695 open please? |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)New behavior
This PR improves rocketpy encoding and introduces decoding functionalities. The way this works is:
to_dict
orfrom_dict
method, they are used to perform the (de)encoding;Breaking change
Additional information
PR #679 should be merged first.
Here are some of the steps that could be improved:
AirBrakes
+Controllers
and new classes.Some important remarks: