DOC: Improve README #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in `cli.py` modify the `ork2notebook` function to use the `Path` class from the `pathlib` module for handling the output folder. Instead of directly assigning the output folder to the `output` variable, the code now creates a `Path` object from the `filepath` and assigns its parent directory to the `output` variable. This commit message follows the established convention of using a prefix to indicate the type of change (`chore` for a non-functional change) and provides a clear and concise description of the purpose of the code changes.
juliomachad0
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check the new readme, see: https://github.com/RocketPy-Team/RocketSerializer/tree/doc/improve-readme