Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: .net8 yak shaving #247

Merged
merged 15 commits into from
Feb 10, 2024
Merged

chore: .net8 yak shaving #247

merged 15 commits into from
Feb 10, 2024

Conversation

RLittlesII
Copy link
Contributor

  • turn the world upside down
  • more bits gone
  • everything is building, tests are failing!
  • chore: all tests passing
  • chore: cleaning

@github-actions github-actions bot added the 🔨 chore Just keeping things neat and tidy label Feb 9, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 464 lines in your changes are missing coverage. Please review.

Comparison is base (c15059b) 46.08% compared to head (a46ec21) 42.09%.

Files Patch % Lines
src/Core/Navigation/ArgumentExtensions.cs 17.85% 69 Missing ⚠️
src/Core/Navigation/ArgumentsBase.cs 21.59% 69 Missing ⚠️
src/Data/Data/DataServiceBase.cs 11.53% 46 Missing ⚠️
src/Core/Exceptions/ExceptionHandlerBase.cs 4.00% 24 Missing ⚠️
src/Core/Locations/GpsLocation.cs 0.00% 21 Missing ⚠️
src/Data/CacheFunctions.cs 13.63% 19 Missing ⚠️
src/Data/DuckDuckGo/DuckDuckGoService.cs 51.61% 15 Missing ⚠️
src/Core/Geofence/GeofenceService.cs 6.66% 14 Missing ⚠️
src/Core/Geofence/Position.cs 25.00% 12 Missing ⚠️
src/Core/Geofence/GeofenceRegion.cs 21.42% 11 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   46.08%   42.09%   -4.00%     
==========================================
  Files          60       55       -5     
  Lines         881      898      +17     
  Branches       42       70      +28     
==========================================
- Hits          406      378      -28     
- Misses        475      520      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RLittlesII RLittlesII enabled auto-merge (squash) February 10, 2024 05:11
@github-actions github-actions bot added this to the v0.11.1 milestone Feb 10, 2024
Copy link

Qodana for .NET

188 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 136
Usage of <inheritdoc /> is invalid 🔶 Warning 24
Invalid XML documentation comment 🔶 Warning 14
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. 🔶 Warning 5
Remove redundant parentheses 🔶 Warning 4
Possible 'null' assignment to non-nullable entity 🔶 Warning 2
Method return value is never used (private accessibility) 🔶 Warning 2
Unused local variable 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@RLittlesII RLittlesII merged commit 2095ebe into master Feb 10, 2024
5 of 7 checks passed
@RLittlesII RLittlesII deleted the chore/the-purge branch February 10, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 chore Just keeping things neat and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant