-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Adonis v5 alpha #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpedroschmitz
force-pushed
the
feature/adonis5-alpha
branch
from
January 26, 2021 17:07
15aa6d0
to
b068aeb
Compare
jpedroschmitz
force-pushed
the
feature/adonis5-alpha
branch
from
January 26, 2021 18:13
b068aeb
to
e414dec
Compare
HigoRibeiro
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.17.1 to 9.18.5. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/9.18.5/CHANGES.md) - [Commits](highlightjs/highlight.js@9.17.1...9.18.5) Signed-off-by: dependabot[bot] <support@github.com>
jpedroschmitz
force-pushed
the
feature/adonis5-alpha
branch
from
January 26, 2021 21:24
b38a5bf
to
d1e9215
Compare
fhugoduarte
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
This PR migrates Adonis Bull to work with Adonis v5 🎉
This is a premajor release, and we will be working to fix bugs and make things stable until Adonis 5 leaves the beta. After that, we will merge it into master and release it as a stable v1. If you find any bug while using the package with version 5, don't hesitate to open an issue and report it 💜
Special thanks
I really want to thanks @RodolfoSilva, @fhugoduarte, and @HigoRibeiro for all their work on the migration!
Additional context
Closes #50.