Skip to content

chore: allow lower case subject #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021
Merged

chore: allow lower case subject #6

merged 1 commit into from
Feb 18, 2021

Conversation

jpedroschmitz
Copy link
Contributor

This PR updates the config to support lower case subject.

With this change, the following commits are valid:

chore: Test
chore: test

Before, just the first commit was a valid one.

@jpedroschmitz jpedroschmitz added the enhancement New feature or request label Feb 17, 2021
@jpedroschmitz jpedroschmitz self-assigned this Feb 17, 2021
@jpedroschmitz jpedroschmitz changed the title chore: allow lower case for subject chore: allow lower case subject Feb 17, 2021
@diego3g diego3g merged commit 6eecb95 into main Feb 18, 2021
@jpedroschmitz jpedroschmitz deleted the chore/allow-lower-case branch February 18, 2021 20:06
@pellizzetti
Copy link
Contributor

pellizzetti commented Feb 18, 2021

This shouldn't've been merged, IMO. @diego3g

Any casing may be used, but it’s ALWAYS best to be consistent. @jpedroschmitz, as OSS lead you should just choose one and go with it.

Besides that, it really seems like a PITA to change renovate to do semantic commits starting with a capital letter, but it is possible.


rant

I never really understood why some conventions would choose to actively enforce lower case subject, anywhere else you fill in a subject you would use uppercase.

It seems that the reason behind that it's something along those lines:

A rule of thumb is that it should be written so to complete the sentence "This change modifies the project to _." That means it does not start with a capital letter, is not a complete sentence, and actually summarizes the result of the change.

But, honestly, this feels like such a stretch. For me, the sole fact that they feel the need to explain it, gives the impression that this specific rule does not make much sense at all.

/rant

@diego3g
Copy link
Member

diego3g commented Feb 19, 2021

Agreed with you @pellizzetti. We just merged this because @jpedroschmitz said that this was blocking renovate itself, but i also think that we need to be consistent. I also agree with the lower case subject you mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants