Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe & more poetic numeral tests #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpecificProtagonist
Copy link

@SpecificProtagonist SpecificProtagonist commented Feb 1, 2021

I added some test cases where Satriani was non-compliant with the spec.
In particular, the old apostrophesIgnored test didn't check for apostrophes in general, but within poetic numerals, where any non-letter (apart from the first .) are ignored. I instead added other checks where apostrophes have to be ignored even when not in peotic numerals, which in most cases (e.g. Foo' is ok) caused Satriani to fail to parse the test. At the moment, single quotes are very annoying to implement correctly for very little benefit, so changing the spec instead would probably be a good idea.

The poetic literal test now also checks for ignoring non-letters and the possibility of non-ASCII letters (which can hang Satriani if used as the start and fail to parse elsewise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant