-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for setting customer_event_alias for BranchEvent #244
Comments
Hi @jf-branch I will analyze the code to understand how it works. Is there any documentation in the SDK guides that explains how this method works? |
you can analyze this issue here: #168 |
@RodrigoSMarques not specifically for customer_event_alias, but the business value is as a subtype or a subname to better distinguish standard or larger events. But this API reference may help: https://help.branch.io/developers-hub/reference/events-api I.e I have a Subscription event, top level its SUBSCRIPTION, but if i wanted to distinguish what type of SUBSCRIPTION i can do so through customer_event_alias:
etc, and then there are some mapping configurations we have when exporting data in which they can use the alias as a filtering field. but the API excepts it for v2/events at the top level for the key 'customer_event_alias', this is what the native SDKs send it as, when set as a property of BranchEvent and i will address: #168 |
Hey @RodrigoSMarques, will this enhancement go out in 7.0.0? |
Hi @jf-branch It will then be replicated in 7.0.0 which I will keep in beta for some time. |
Amazing! Great work. Thank you so much! |
## 6.9.0 ### Enhancement * Issue #244 - Support for setting customer_event_alias for BranchEvent
@jf-branch |
## 7.0.0-beta.3⚠️ This is a major release which contains breaking API changes. ### BREAKING CHANGE - * Minimum required Dart SDK version to 2.18 (Flutter 3.3.0) * Xcode 15 is the min version * iOS 12 is the min version #### SDK Initialization Required * Use `FlutterBranchSdk.init()` method to initialize the SDK. Initialization must be called from `main` or at any time (for example after getting consent for GPDR). ```dart await FlutterBranchSdk.init( useTestKey: false, enableLogging: false, disableTracking: false); ``` Check additional instructions in the README #### Deprecated / Removed - * `FlutterBranchSdk.initSession()`. Use `FlutterBranchSdk.listSession()`. * Removed `setIOSSKAdNetworkMaxTime` method * Removed Facebook App Install Ads on iOS ### Features - * Issue #244 - Support for setting customer_event_alias for BranchEvent * Updated compile & target SDK to Android API 33. * Updated example app Android compileSdkVersion to 33. ### Native SDK Updates - * Updated included iOS SDK to 3.0.0 - [iOS Version History](https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/releases)
Feature Request
The Branch v2 Events API and the native iOS SDKs support associating an event alias property to standard and custom events, but this does not seem exposed through the Flutter Event interface.
iOS declaration of BranchEvent.alias: https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/blob/master/BranchSDK/BranchEvent.h#L78
Android declartion of BranchEvent.setCustomerEventAlias : https://github.com/BranchMetrics/android-branch-deep-linking-attribution/blob/master/Branch-SDK/src/main/java/io/branch/referral/util/BranchEvent.java#L71
Could we please request to support exposing setting of this parameter through flutter_event.dart's BranchEvent: https://github.com/RodrigoSMarques/flutter_branch_sdk/blob/master/lib/src/objects/branch_event.dart#L49
Thank you!
Best,
Justin
The text was updated successfully, but these errors were encountered: