Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate when error is thrown in init #270

Closed
apackin opened this issue Dec 14, 2023 · 2 comments
Closed

Indicate when error is thrown in init #270

apackin opened this issue Dec 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@apackin
Copy link

apackin commented Dec 14, 2023 •
edited
Loading

flutter_branch_sdk/ios/Classes/SwiftFlutterBranchSdkPlugin.swift

Line 299 in f5d2753

message: err.localizedDescription,

This code path includes print("Branch InitSession error to indicate when an error is thrown from this path because it's useful for debugging. It would be helpful for debugging production issues as well if this information was passed along.

Perhaps we can include something along the lines of "InitSession error" in the message passed to FlutterError?
As in message: "InitSession error: \(err.localizedDescription)", instead of just message: err.localizedDescription,
@RodrigoSMarques
Copy link
Owner

Thanks for the sugestion. I will include it in the next version of the package.

@RodrigoSMarques RodrigoSMarques added the enhancement New feature or request label Dec 14, 2023
RodrigoSMarques added a commit that referenced this issue Dec 19, 2023
@RodrigoSMarques
Native SDK Updates / Indicate when error is thrown in init
3faad81 
* Fix issue #270: Indicate when error is thrown in init

### Native SDK Updates

* Updated included Android SDK to 5.8.0 - [Android Version History](https://github.com/BranchMetrics/android-branch-deep-linking-attribution/releases)
@RodrigoSMarques RodrigoSMarques mentioned this issue Dec 20, 2023
Merged
@RodrigoSMarques
Copy link
Owner

Fixed in version 7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apackin @RodrigoSMarques