Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carons #1

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix carons #1

merged 1 commit into from
Mar 18, 2024

Conversation

Finii
Copy link

@Finii Finii commented Mar 18, 2024

[why]
The carons are all upside down and look like a small circumflex. The dcaron and tcaron use a caron instead of an apothrophe.

[how]

  • Flip caron glyph
  • Add combining-comma-above-right (shortened version from comma)
  • Recreate dcaron and tcaron from d/t and that new glyph
  • Increase version number (patchlevel by one)
  • Mention Rodrigo in copyright.

See also

[why]
The carons are all upside down and look like a small circumflex.
The dcaron and tcaron use a caron instead of an apothrophe.

[how]
- Flip caron glyph
- Add combining-comma-above-right (shortened version from comma)
- Recreate dcaron and tcaron from d/t and that new glyph
- Increase version number (patchlevel by one)
- Mention Rodrigo in copyright.

See also ryanoasis/nerd-fonts#1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Author

Finii commented Mar 18, 2024

@Finii
Copy link
Author

Finii commented Mar 18, 2024

image

@Finii Finii marked this pull request as ready for review March 18, 2024 14:26
@Finii
Copy link
Author

Finii commented Mar 18, 2024

This does not build the font files, it just changes the sfd.
So probably you want to build before merging to your fork.

This is now used for Nerd Fonts, see

@jesusmgg
Copy link

Looks great, let's merge this.

@Rodrigodd Rodrigodd merged commit 166c1d4 into Rodrigodd:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants