Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to fix active-enum and passive-enum commands #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DexterNano
Copy link

Changed the format of passive-enum and active-enum commands from “-” to “” because they are invoked with “”.

Changed the format of passive-enum and active-enum commands from “-” to “_” because they are invoked with “_”.
@RoganDawes
Copy link
Owner

RoganDawes commented Mar 6, 2025

Not sure why you believe that the command should be passive_enum? I see the following in the actual code (as opposed to documentation):

logitacker/logitacker_cli.c:    NRF_CLI_CMD(passive-enum, NULL, "enter passive enumeration mode", cmd_discover_onhit_passiveenum),
logitacker/logitacker_cli.c:        NRF_CLI_CMD(passive-enum, NULL, "start passive enumeration of newly paired device", cmd_pair_sniff_onsuccess_passiveenum),
logitacker/logitacker_cli.c:        NRF_CLI_CMD(active-enum, NULL, "start passive enumeration of newly paired device", cmd_pair_sniff_onsuccess_activeenum),
logitacker/logitacker_cli.c:    NRF_CLI_CMD(passive-enum, NULL, "enter passive enumeration", cmd_inject_onsuccess_passiveenum),
logitacker/logitacker_cli.c:    NRF_CLI_CMD(passive-enum, NULL, "enter passive enumeration", cmd_inject_onfail_passiveenum),
logitacker/logitacker_cli.c:    NRF_CLI_CMD(passive-enum, &m_sub_options_passiveenum, "options for passive-enum mode", cmd_help),

And https://docs.nordicsemi.com/bundle/sdk_nrf5_v16.0.0/page/group_nrf_cli.html#gadad7620e8e2c98c0d983963f80e2aff8 indicates that the first parameter should be the text of the command option.

Does the code not work with active-enum/passive-enum ?

@DexterNano
Copy link
Author

DexterNano commented Mar 10, 2025

Hi, thanks for the rapid response.

For some reason it does not seam to work for me

LOGITacker (discover) $ active-enum B4:8F:96:**:**
active-enum: command not found

VS

LOGITacker (discover) $ active_enum B4:8F:96:**:**
Starting active enumeration for device B4:8F:96:**:**

Maybe it has something to do with my spanish keyboard? But i can´t see how that can be the problem

@RoganDawes
Copy link
Owner

Hmm, interesting! I wonder if that is an artifact of some deeper processing in the Nordic SDK. I will have to look deeper into it, I guess! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants