Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition; reading, logging #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

laldoroty
Copy link
Collaborator

No description provided.

@laldoroty laldoroty requested a review from wmwv November 7, 2024 16:36
@wmwv
Copy link

wmwv commented Nov 7, 2024

  1. Can you be more specific about the original problem?
  2. Please add a test that demonstrates the problem and that these changes fix it.

@wmwv
Copy link

wmwv commented Nov 7, 2024

Is the following snippet of text the thing that this PR is fixing?

           # NOTE -- we were getting weird race condition issues where sometimes
             #   the FITS header reading failed.  We aren't sure exactly what's going
             #   on, but the hypothesis is bad filesystem behavior.  The earlier
             #   writefits returns, but somehow the file wasn't really fully written
             #   to either disk, or to the memory buffers that the fits.getheader
             #   here read.  Put in an ugly hack of retring and sleeping to work
             #   around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants