-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example CLM support #786
base: main
Are you sure you want to change the base?
Example CLM support #786
Conversation
I dont think hard coding the install dir makes sense, as this would remove the choice for users / company admins to install the App to a different folder. Me for myself wont need that feature, but I can understand the need for company admins to change the dir |
@FaserF this is proof of concept, definitely not ready for an immediate merge. The most important thing is stops the code in the custom actions from being dot sourced (and therefore failing) in devices that run PowerShell CLM. I'm sure the same thing could be done by removing the |
The same issue also exists for the the CA_PowerShell_Uninstall statement. It didn't cause the uninstall to fail, but it doesn't remove the tasks. I've included that example here as well. |
This behavior can also be corrected by wrapping the statement into a |
Proposed Changes
This is an example that changes how PowerShell is launched during the installation process.
Proof of concept to demonstrate it remediates the issue with Constrained Language Mode. Also includes a build script for running wix.
Not really viable for everyone since it hard codes the expected paths to the defaults on the C: drive.
Related Issues
#783