fix: Fix React app build error #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the React app build error that happens when running rpm run build in ‘app’. The update includes these changes: - Fixed the issue where ESLint was not being properly applied to app directory due to directory reference error. This was resolved by creating .eslintrc file in ‘web’ directory and installing ESLint as dev dependency in ‘app’. - Fixed the package dependency conflicts of ‘app’ by updating packages to latest version compatible with React 17. - Fixed the issue where React build would not run due to React version conflict between eslint-plugin-react and react-script. This was resolved by creating .env file that allowed ignoring ESLint while running React script. - Updated package.json, package-lock.json of ‘root’, ‘web’, ‘app’, and ‘api’. package-lock.json for ‘app’ and ‘api’ were deleted as they were not necessary. - Minor fix in .vscode/settings.json to fix regex errors. - Minor fix in app/public/index.html to fix regex errors based on ESLint. Fixes #73
yunchae-kim
commented
Sep 14, 2023
| "eslint-config-airbnb": "^19.0.4", | ||
| "eslint-config-airbnb-base": "^15.0.0", | ||
| "eslint-config-node": "^4.1.0", |
There was a problem hiding this comment.
eslint-config-node deleted as now not needed.
yunchae-kim
commented
Sep 14, 2023
Comment on lines
-40
to
54
| "type" : "rule", | ||
| "selector" : /^&/ | ||
| "type": "rule", | ||
| "selector": "^&" | ||
| }, | ||
| { | ||
| "type" : "rule", | ||
| "selector" : /^&:\w+$/ | ||
| "type": "rule", | ||
| "selector": "^&:\\w+$" | ||
| }, | ||
| { | ||
| "type" : "rule", | ||
| "selector" : /^&: : \w+$/ | ||
| "type": "rule", | ||
| "selector": "^&: : \\w+$" | ||
| }, | ||
| { | ||
| "type" : "at-rule", | ||
| "name" : "media" | ||
| "type": "at-rule", | ||
| "name": "media" | ||
| } |
yunchae-kim
commented
Sep 14, 2023
| @@ -53,10 +53,8 @@ | |||
| "import/prefer-default-export": ["warn", { "target": "any" }], | |||
| "import/no-duplicates": ["error", { "considerQueryString": true }], | |||
| "simple-import-sort/imports": "error", | |||
| "simple-import-sort/exports": "error", | |||
There was a problem hiding this comment.
Deleted simple-import-sort/exports as it is not needed.
yunchae-kim
commented
Sep 14, 2023
There was a problem hiding this comment.
Moved eslintignore to web to make it work properly.
yunchae-kim
commented
Sep 14, 2023
Comment on lines
-32
to
-34
| "eslintConfig": { | ||
| "extends": "react-app" | ||
| }, |
There was a problem hiding this comment.
Deleted as it conflicts with eslint setup in root.
yunchae-kim
commented
Sep 14, 2023
| "@testing-library/jest-dom": "^6.1.3", | ||
| "@testing-library/react": "^12.0.0", | ||
| "@testing-library/user-event": "^12.0.0", | ||
| "eslint": "^8.49.0", |
There was a problem hiding this comment.
Added to let eslint rule referenced properly in web directory.
yunchae-kim
commented
Sep 14, 2023
| @@ -23,7 +21,7 @@ | |||
| work correctly both with client-side routing and a non-root public URL. | |||
| Learn how to configure a non-root public URL by running `npm run build`. | |||
| --> | |||
| <title>ComptoxAI – Interactive data portal</title> | |||
| <title>ComptoxAI – Interactive data portal</title> | |||
There was a problem hiding this comment.
minor regex change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#73] Refer to GitHub issue...
This update fixes the React app build error that happens when running rpm run build in ‘app’.
The update includes these changes:
Fixes #73