style: Resolve ESLint conflict with eslint-plugin-prettier #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#62] Refer to GitHub issue... This update addresses the ESLint conflicts between eslint-plugin-prettier and our ESLint rules. The conflicts caused issues with automatic double-quoting of JavaScript strings, overriding our preference for single quotes. We have decided to replace eslint-plugin-prettier with the prettier-eslint extension in VSCode for better ESLint and Prettier compatibility. Changes made in this update: - Removed eslint-plugin-prettier from package.json. - Removed eslint-plugin-sort-exports, as we now use eslint-plugin-simple-import-sort for sorting React exports. - Updated package-lock.json accordingly. - Added rvest.vs-code-prettier-eslint to .vscode/extensions.json for prettier-eslint compatibility. - Changed default formatters in .vscode/settings.json from esbenp.prettier-vscode (Prettier) to rvest.vs-code-prettier-eslint (Prettier ESLint). - Removed all eslint-plugin-prettier and eslint-plugin-sort-exports references from .eslintrc. - Turned off the import/order rule to avoid conflicts with simple-import-sort/imports.
yunchae-kim
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#62] Refer to GitHub issue...
This update addresses the ESLint conflicts between eslint-plugin-prettier and our ESLint rules. The conflicts caused issues with automatic double-quoting of JavaScript strings, overriding our preference for single quotes. We have decided to replace eslint-plugin-prettier with the prettier-eslint extension in VSCode for better ESLint and Prettier compatibility.
Changes made in this update: