feat(vue3): various upgrades for vue 3 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.4 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.4...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ard navigation overrides (RonaldJerez#79) Co-authored-by: Sarah Leventhal <sarah.leventhal@mastercard.com>
…k is passed (RonaldJerez#80) Co-authored-by: Sarah Leventhal <sarah.leventhal@mastercard.com>
…on events when no mask passed
…ic key from consuming apps (RonaldJerez#83) Co-authored-by: Sarah Leventhal <sarah.leventhal@mastercard.com>
Robo-Rin
force-pushed
the
beta
branch
5 times, most recently
from
7e70e01 to
faa796e
Compare
Upgrades dependencies, migrates to storybook + vite, removes default export. BREAKING CHANGE: Users will have to use es6-style named imports instead. closes RonaldJerez#44, closes RonaldJerez#52
|
🎉 This PR is included in version 3.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i.e.
Rationale for removing default export
Previously we were using
vue-cli-service buildbut now we are using vite + rollup. Rollup gives the following warning:Since it's bad practice to mix default and named exports and since Vue 3 is a breaking change already, I thought it would be a good opportunity to remove it.
Read more on why it's bad practice here: rollup/rollup#1961 (comment)
Checklist