feat: add support to render rss item tags #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maooyer
changed the title
Rongronggg9
requested changes
Apr 19, 2024
|
I've converted the PR into a draft to make its status clearer. Feel free to convert it back when it is ready :) |
maooyer
changed the title
Rongronggg9
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM. I will create migration files and merge this PR after #451 (which is under my final tests).
Note that I plan to rename display_item_tags to display_entry_tags to make it clearer. If you'd like to, you may do this before I start merging this, or just let me do it later.
Rongronggg9
force-pushed
the
feat/render-rss-item-tags
branch
from
bc71daa to
5c15c5a
Compare
With corresponding migration files. Co-authored-by: maooyer <maooyer@gmail.com> Signed-off-by: Rongrong <i@rong.moe>
Co-authored-by: maooyer <maooyer@gmail.com> Signed-off-by: Rongrong <i@rong.moe>
Co-authored-by: maooyer <maooyer@gmail.com> Signed-off-by: Rongrong <i@rong.moe>
Signed-off-by: Rongrong <i@rong.moe>
Rongronggg9
force-pushed
the
feat/render-rss-item-tags
branch
from
5c15c5a to
179296d
Compare
|
Almost done! 🎉 Remaining tasks:
|
Fix entry hashtags by replacing any punctuations and whitespaces by '_'. Signed-off-by: Rongrong <i@rong.moe>
Signed-off-by: Rongrong <i@rong.moe>
|
Merged. Thanks for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to render RSS item tags.
close #318
Type of change
Please delete options that are not relevant.