-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we still have multiple issues regarding performance for select all, doing undo and redo, movement improved but can be more #174
Comments
Not just select all nodes. There is a problem of selecting a large number of nodes. My initial checks in the past few hours show that the trigger has a lot of CPU usage My test method:
I'd profile the app using this simple senario (for just focusing on the selection) and in the result:
I am trying to find a way to emit this signal once and optimize the code |
Update 1: I changed the code so that the selectedModelChanged signal is emitted only once, but the problem was not solved (Of course, this change should be applied in any case). This method still consumes a lot event in case of emitting the signal once. This is the execution time of this method, as the number of selected nodes increases, the execution time also increases (in this process, the mouse button is not released).
Apparently, the problem is due to the bindings given to property SelectionModel.selectedModel. In places like checking if node is selected or not. Currently, I am trying to understand where this binding takes the most time. Update 2: |
Originally posted by @l3enQ in #170 (comment)
The text was updated successfully, but these errors were encountered: