Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: In SelectionModel, the selectNode function has performance issue. #179

Open
mohsenkondori opened this issue Jan 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mohsenkondori
Copy link
Collaborator

mohsenkondori commented Jan 28, 2024

Describe the bug
Within the SelectionModel class, it is crucial for the SelectNode function to be robust. SelectNode should adeptly manage both the "select all" and individual node selection scenarios, ensuring the emission of the appropriate signals to prevent unnecessary actions that could lead to performance issues.

Check it: #174

To Reproduce
Steps to reproduce the behavior:

  1. Run the app in the profile mode
  2. Select all nodes, you can see the app is slow in selecting model.
  3. See the profile results.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Software Versions
Application version: (add either official git release version or git SHA)
Firmware version: (add either official git release version or git SHA)

Additional context
Add any other context about the problem here.

@mohsenkondori mohsenkondori added the bug Something isn't working label Jan 28, 2024
@mohsenkondori mohsenkondori self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant