Images flickable has performance bug #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l3enQ
requested changes
Jan 31, 2024
resources/Core/SelectionModel.qml
Outdated
Comment on lines
109
to
123
| Object.values(nodes).forEach(node => { | ||
| selectNode(node); | ||
| selectedModel[node._qsUuid] = node; | ||
| }); | ||
|
|
||
| Object.values(links).forEach(link => { | ||
| selectLink(link); | ||
| selectedModel[link._qsUuid] = link; | ||
| }) | ||
|
|
||
| Object.values(containers).forEach(container => { | ||
| selectContainer(container); | ||
| selectedModel[container._qsUuid] = container; | ||
| }) | ||
|
|
||
| selectedModelChanged(); | ||
|
|
||
| } |
There was a problem hiding this comment.
fixing another issue for select all performance! mention in the description!
but it will not fix selecting with marquee performance bug!
…l class to prevent excess calls.
…er and selectNode functions).
l3enQ
reviewed
Feb 4, 2024
There was a problem hiding this comment.
@mohsenkondori please check my changes
@HamedMasafi we need to profile it
l3enQ
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Images flickable has performance bug when all nodes are selected fixed
Fixing #178 , #179
Type of change
Checklist: