snap for multiple connections enabled #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l3enQ
requested changes
Jan 13, 2024
@l3enQ yes, it is now enabled |
l3enQ
requested changes
Jan 16, 2024
resources/Core/Scene.qml
Outdated
Comment on lines
241
to
243
| function snappedPosition (position) { | ||
| return Qt.vector2d(Math.ceil(position.x / 20) * 20, Math.ceil(position.y / 20) * 20); | ||
| } |
There was a problem hiding this comment.
can we update this function so it snap to nearest grid not the next one?!
i.e., using round and not ceil
There was a problem hiding this comment.
also please check if we have the grid size some where like NLStyle or not!
resources/View/NodeView.qml
Outdated
| node.guiConfig.position.x = Math.ceil(node.guiConfig.position.x / 20) * 20; | ||
| } | ||
| if(NLStyle.snapEnabled) | ||
| node.guiConfig.position = Qt.vector2d(Math.ceil(node.guiConfig.position.x / 20) * 20, Math.ceil(node.guiConfig.position.y / 20) * 20) |
There was a problem hiding this comment.
can we use the same function in scene?
| @@ -121,6 +121,10 @@ Item { | |||
| if (obj?.objectType === NLSpec.ObjectType.Node) { | |||
| obj.guiConfig.position.x += deltaX; | |||
| obj.guiConfig.position.y += deltaY; | |||
|
|
|||
| if(NLStyle.snapEnabled) | |||
There was a problem hiding this comment.
we can use another style, so we just snap the top left position of this view not nodes! but let's keep it as you did
|
@l3enQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
snap for multiple connections enabled
Fixes #155
Type of change
Checklist: