feat: Enter key triggers approval when action buttons are visible #10357
+23
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to address Issue #10350. When action buttons (like Approve/Reject, Save/Reject, Run/Reject) are visible, pressing Enter now triggers the primary button action (approval) instead of denial.
Changes
ChatTextArea.tsx: Added two new optional props
enablePrimaryButtonandonPrimaryButtonClick. Modified the Enter key handler to callonPrimaryButtonClickwhen the primary button is enabled.ChatView.tsx: Pass
enablePrimaryButtonandonPrimaryButtonClickprops to ChatTextArea component.Behavior Change
Testing
Feedback and guidance are welcome!