Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Dec 28, 2025

The tool name field is an enum, but custom tool names are dynamic. Follow the MCP tool pattern of just tracking all the custom tools in a single bucket.


Important

Custom tools are now tracked as custom_tool for usage and error recording, similar to MCP tools, with tests added for validation.

  • Behavior:
    • Custom tools are now recorded as custom_tool in presentAssistantMessage.ts, similar to MCP tools.
    • Custom tool errors are recorded with the name custom_tool.
    • Partial tool blocks are not recorded.
  • Tests:
    • Added presentAssistantMessage-custom-tool.spec.ts to test custom tool usage and error recording.
    • Tests cover scenarios with enabled/disabled experiments and partial blocks.
  • Misc:
    • Added custom_tool to toolNames in tool.ts and TOOL_DISPLAY_NAMES in tools.ts.

This description was created by Ellipsis for a582f9b. You can customize this summary. It will automatically update as commits are pushed.

The tool name field is an enum, but custom tool names are dynamic.
Follow the MCP tool pattern of just tracking all the custom tools in
a single bucket.
@jr jr requested review from cte and mrubens as code owners December 28, 2025 04:28
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Dec 28, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 28, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found. The PR correctly handles custom tools similarly to MCP tools by tracking them in a single "custom_tool" bucket for IPC schema purposes.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2025
@jr jr merged commit a42387e into main Dec 29, 2025
29 of 31 checks passed
@jr jr deleted the jr/custom-tool-schema branch December 29, 2025 16:58
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants