Skip to content

Fix Package Publish Workflow #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ColemanRoo merged 8 commits into from
Nov 20, 2024
Merged

Fix Package Publish Workflow #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f316595
fixing access to codeartifact login script
ColemanRoo Nov 19, 2024
adfdf17
adjust namespace to match other Roo packages
ColemanRoo Nov 19, 2024
a2b10da
addling line to install vsce to Github action
ColemanRoo Nov 19, 2024
1eb658a
removing namespace as it is not valid for extension name
ColemanRoo Nov 19, 2024
9d9b69f
version bump
ColemanRoo Nov 19, 2024
0fe41c5
updating package-lock and doing full install for publish action
ColemanRoo Nov 19, 2024
d9f1c47
update workflow package install steps
ColemanRoo Nov 19, 2024
d4711b5
update package install steps
ColemanRoo Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,19 @@ jobs:
git config user.name github-actions
git config user.email github-actions@github.com
- run: |
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a Node.js script with async/await for handling asynchronous operations instead of shell commands. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6

npm install -g vsce
npm run co:login
latest_published_version=$(npm show @roo-dev/roo-cline version)
latest_published_version=$(npm show roo-cline version)
current_package_version=$(node -p "require('./package.json').version")
echo "Latest published version: $latest_published_version"
echo "Current package version: $current_package_version"
if [ "$latest_published_version" == "$current_package_version" ]; then
echo "Latest version is already published to NPM"
else
npm install
cd webview-ui
npm install
cd ..
npm run vsix
npm publish
echo "Successfully published to NPM"
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file modified scripts/codeartifact-login.sh
100644 → 100755
View file
Open in desktop
Empty file.