fix(providers): do not force openai-strict tools for zai/ollama#11406
Open
0xMink wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix(providers): do not force openai-strict tools for zai/ollama#114060xMink wants to merge 1 commit intoRooCodeInc:mainfrom
0xMink wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
Contributor
No issues found. The change is minimal, type-safe, and consistent with the existing OpenRouter pattern that already passes tools directly to Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11404
Summary
convertToolsForOpenAI()wrapper from Z-AI and Ollama handlers, passing tools directly toconvertToolsForAiSdk()insteadstrict: true, forces all properties torequired, and setsadditionalProperties: false-- constraints that GLM and Qwen models do not support, causing malformed or missing tool call argumentsTest plan