fix: cancel backend auto-approval timeout when auto-approve is toggled off mid-countdown

[SannidhyaSah]

Related GitHub Issue

Closes: N/A

Roo Code Task Context (Optional)

No Roo Code task context for this PR

Description

When a user disables auto-approve while a followup question countdown timer is actively running, only the visual timer in the UI was removed — the backend setTimeout in Task.ts continued running and eventually auto-submitted the answer anyway.

Root cause: ChatView.tsx was not passing the onFollowUpUnmount callback to ChatRow, so when FollowUpSuggest's useEffect cleanup function fired (due to autoApprovalEnabled changing to false), the onCancelAutoApproval?.() call was a no-op since the callback was undefined. The backend was never notified to cancel its pending timeout.

Fix:

1. Added a handleFollowUpUnmount callback in ChatView.tsx that sends a cancelAutoApproval message to the backend
2. Passed it as the onFollowUpUnmount prop to ChatRow

Now the full cancellation chain works:
FollowUpSuggest useEffect cleanup → onCancelAutoApproval() → handleFollowUpUnmount() → vscode.postMessage({ type: "cancelAutoApproval" }) → webviewMessageHandler.ts → task.cancelAutoApprovalTimeout() → clears the backend setTimeout

Test Procedure

1. Automated tests:

   • Added 2 new tests in FollowUpSuggest.spec.tsx:
     • should call onCancelAutoApproval when autoApprovalEnabled changes to false during countdown
     • should call onCancelAutoApproval when alwaysAllowFollowupQuestions changes to false during countdown
   • All 20 FollowUpSuggest tests pass
   • All 24 ChatView tests pass
   • All 5 ChatRow tests pass
   • Full pnpm test suite: 5428 tests passed, 46 skipped

2. Manual testing steps:

   • Enable auto-approve with follow-up questions auto-approve enabled
   • Send a message that triggers a follow-up question with suggestions
   • While the countdown timer is visible on the first suggestion, toggle auto-approve off
   • Verify: The countdown timer disappears AND the answer is NOT auto-submitted after the original timeout duration

Pre-Submission Checklist

• Issue Linked: This PR addresses a bug in the auto-approve countdown cancellation flow.
• Scope: Changes are focused on fixing the missing callback propagation (2 files changed).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New tests added to cover the toggle-off-mid-countdown scenario.
• Documentation Impact: No documentation updates required.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No UI changes in this PR — the fix ensures existing UI behavior (timer disappearing) is properly synchronized with the backend.

Documentation Updates

• No documentation updates are required.

Additional Notes

Files changed:

• webview-ui/src/components/chat/ChatView.tsx — Added handleFollowUpUnmount callback and passed it as onFollowUpUnmount prop to ChatRow
• webview-ui/src/components/chat/__tests__/FollowUpSuggest.spec.tsx — Added 2 regression tests for the toggle-off-mid-countdown scenario

Get in Touch

Sa

[roomote]

Rooviewer   See task

Reviewed with no issues found. The fix correctly wires up the missing onFollowUpUnmount callback from ChatView to ChatRow, completing the cancellation chain so the backend setTimeout is properly cleared when auto-approve is toggled off mid-countdown. All 20 FollowUpSuggest and 24 ChatView tests pass.

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}