Skip to content

Conversation

@System233
Copy link
Contributor

@System233 System233 commented Feb 26, 2025

Description

Fix #1165

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Replace parseInt with parseFloat for price parsing in ApiOptions.tsx to correctly handle decimal values.

  • Behavior:
    • Change parseInt to parseFloat for parsing input and output prices in ApiOptions.tsx.
    • Ensures decimal values are correctly parsed for openAiCustomModelInfo prices.
  • Functions:
    • handleInputChange in ApiOptions.tsx now uses parseFloat for price parsing.
  • Misc:
    • No changes to documentation or additional tests noted.

This description was created by Ellipsis for f3d0203. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: f3d0203

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 26, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2025
@mrubens mrubens merged commit 6d38e34 into RooCodeInc:main Feb 26, 2025
17 checks passed
@ksze
Copy link
Contributor

ksze commented Mar 7, 2025

There is still a problem in that, while Roo can now parse a non-integer for the pricing, it still doesn't allow me to type a non-integer into the pricing fields. It does nothing when I press the "." on the keyboard. The workaround is to type the non-integer pricing somewhere else and then copy and paste into the pricing field.

@System233
Copy link
Contributor Author

There is still a problem in that, while Roo can now parse a non-integer for the pricing, it still doesn't allow me to type a non-integer into the pricing fields. It does nothing when I press the "." on the keyboard. The workaround is to type the non-integer pricing somewhere else and then copy and paste into the pricing field.

Thanks for the feedback. Due to changes in another PR, this feature has problems again. A new patch #1464 has been pushed to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model input and output prices must be whole numbers only.

3 participants