Fix for focus grabbing when follow-up returns + Unit Test

[diarmidmackenzie]

Context

See issue 1 in this discussion: #1358

When "ask followup question" tool is invoked, Roo grabs focus away from whateever the user is doing which is annoying.

Implementation

A localized fix for the "ask followup question" tool, for reasons explained here: #1358 (comment)

Product code change was simple. Getting a Unit Test that reproduced the failure with the old code change proved rather tricky, but I got there in the end.

Screenshots

N/A

How to Test

Ask Roo to ask you a follow-up question (doesn't matter what).
Move your focus aay from the text area - e.g. start typing into another file.
Observe that when the follow up question is ready, focus does not get grabbed.

A couple of other focus-grabs that remain (I took care not to break these).

• Switching into the Roo extension context from another extension
• Switching to the Roo chat tab from another tab.

-->

Get in Touch

diarmid/diarmidm on Discord.

---

Important

Fixes focus grabbing issue in ChatView.tsx for follow-up questions and adds a unit test to verify the behavior.

• Behavior:
  • Fixes focus grabbing issue in ChatView.tsx when a follow-up question is presented by setting setEnableButtons(true) to prevent focus change.
• Testing:
  • Adds a unit test in ChatView.test.tsx to verify that focus is not grabbed when a follow-up question is presented.
  • Uses mockFocus to track focus calls and ensures it remains unchanged after follow-up questions.

^{This description was created by for cf6bb38. It will automatically update as commits are pushed.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: cf6bb38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[diarmidmackenzie]

While this fixes the immediate issue, I have found some other related bugs, and a broader fix is probably warranted.

See notes here:
#2189 (comment)

In particular, ChatView needs a dedicated piece of state to record whether the TextArea is / is not focussed, because it can't reliably derive this from other state.

That will allow us to fix a range of related bugs in this area, as noted in #2189. I will pull together a further PR for this.

[libertyteeth]

That will allow us to fix a range of related bugs in this area, as noted in #2189. I will pull together a further PR for this.

I mentioned this in #2189 (comment) , just wanted to note it here: I've worked on a fairly comprehensive state machine for maintaining focus.

It may be lacking a few edge cases? I put it here a few days ago, then got busy with life :)

https://github.com/libertyteeth/roo-fixes/pull/2