Skip to content

fix(webview): Fix links to filename:0 #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
May 19, 2025
Merged

fix(webview): Fix links to filename:0 #3727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c20c5d
fix(webview): Fix links to filename:0
RSO May 19, 2025
8123bab
Add changeset
RSO May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-paths-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"roo-cline": patch
---

Fixed bug that prevented some file links from working in the Agent output
4 changes: 3 additions & 1 deletion src/integrations/misc/open-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ export async function openFile(filePath: string, options: OpenFileOptions = {})

const document = await vscode.workspace.openTextDocument(uri)
const selection =
options.line !== undefined ? new vscode.Selection(options.line - 1, 0, options.line - 1, 0) : undefined
options.line !== undefined
? new vscode.Selection(Math.max(options.line - 1, 0), 0, Math.max(options.line - 1, 0), 0)
: undefined
await vscode.window.showTextDocument(document, {
preview: false,
selection,
Expand Down
Loading