Skip to content

[Condense] Show indicator message when context is condensing #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 3 commits into from
May 21, 2025
Merged

[Condense] Show indicator message when context is condensing #3765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66bd209
[Condense] Show indicator message when context is condensing
canrobins13 May 20, 2025
7a4afb7
changeset
canrobins13 May 20, 2025
5c42833
translations
canrobins13 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-emus-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"roo-cline": patch
---

Add a UI indicator while the context is condensing
5 changes: 4 additions & 1 deletion webview-ui/src/components/chat/ChatRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { Markdown } from "./Markdown"
import { CommandExecution } from "./CommandExecution"
import { CommandExecutionError } from "./CommandExecutionError"
import { AutoApprovedRequestLimitWarning } from "./AutoApprovedRequestLimitWarning"
import { ContextCondenseRow } from "./ContextCondenseRow"
import { CondensingContextRow, ContextCondenseRow } from "./ContextCondenseRow"

interface ChatRowProps {
message: ClineMessage
Expand Down Expand Up @@ -929,6 +929,9 @@ export const ChatRowContent = ({
/>
)
case "condense_context":
if (message.partial) {
return <CondensingContextRow />
}
return message.contextCondense ? <ContextCondenseRow {...message.contextCondense} /> : null
default:
return (
Expand Down
12 changes: 11 additions & 1 deletion webview-ui/src/components/chat/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,8 +979,18 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
result.push([...currentGroup])
}

if (isCondensing) {
// Show indicator after clicking condense button
result.push({
Copy link
Contributor Author

@canrobins13 canrobins13 May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this approach, but it feels like overkill to add a new ClineMessage to the history and then deal with conditional logic around when to display it vs not, when all we really care about is showing a loading indicator in the UI

type: "say",
say: "condense_context",
ts: Date.now(),
partial: true,
})
}

return result
}, [visibleMessages])
}, [isCondensing, visibleMessages])

// scrolling

Expand Down
25 changes: 25 additions & 0 deletions webview-ui/src/components/chat/ContextCondenseRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { VSCodeBadge } from "@vscode/webview-ui-toolkit/react"

import { ContextCondense } from "@roo/schemas"
import { Markdown } from "./Markdown"
import { ProgressIndicator } from "./ProgressIndicator"

export const ContextCondenseRow = ({ cost, prevContextTokens, newContextTokens, summary }: ContextCondense) => {
const { t } = useTranslation()
Expand All @@ -14,6 +15,19 @@ export const ContextCondenseRow = ({ cost, prevContextTokens, newContextTokens,
<div
className="flex items-center justify-between cursor-pointer select-none"
onClick={() => setIsExpanded(!isExpanded)}>
<div
style={{
width: 16,
height: 16,
display: "flex",
alignItems: "center",
justifyContent: "center",
}}>
<span
className={`codicon codicon-check`}
style={{ color: "var(--vscode-charts-green)", fontSize: 16, marginBottom: "-1.5px" }}
/>
</div>
<div className="flex items-center gap-2 flex-grow">
<span className="codicon codicon-compress text-blue-400" />
<span className="font-bold text-vscode-foreground">{t("chat:contextCondense.title")}</span>
Expand All @@ -33,3 +47,14 @@ export const ContextCondenseRow = ({ cost, prevContextTokens, newContextTokens,
</div>
)
}

export const CondensingContextRow = () => {
const { t } = useTranslation()
return (
<div className="flex items-center gap-2">
<ProgressIndicator />
<span className="codicon codicon-compress text-blue-400" />
<span className="font-bold text-vscode-foreground">{t("chat:contextCondense.condensing")}</span>
</div>
)
}
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/ca/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Context condensat",
"condensing": "Condensant context...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/de/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Kontext komprimiert",
"condensing": "Kontext wird komprimiert...",
"tokens": "Tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/en/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
},
"contextCondense": {
"title": "Context Condensed",
"condensing": "Condensing context...",
"tokens": "tokens"
},
"instructions": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/es/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Contexto condensado",
"condensing": "Condensando contexto...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/fr/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Contexte condensé",
"condensing": "Condensation du contexte...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/hi/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "संदर्भ संक्षिप्त किया गया",
"condensing": "संदर्भ संघनित कर रहा है...",
"tokens": "टोकन"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/it/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Contesto condensato",
"condensing": "Condensazione del contesto...",
"tokens": "token"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/ja/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "コンテキスト要約",
"condensing": "コンテキストを圧縮中...",
"tokens": "トークン"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/ko/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "컨텍스트 요약됨",
"condensing": "컨텍스트 압축 중...",
"tokens": "토큰"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/nl/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
},
"contextCondense": {
"title": "Context samengevat",
"condensing": "Context aan het samenvatten...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/pl/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Kontekst skondensowany",
"condensing": "Kondensowanie kontekstu...",
"tokens": "tokeny"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/pt-BR/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Contexto condensado",
"condensing": "Condensando contexto...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/ru/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
},
"contextCondense": {
"title": "Контекст сжат",
"condensing": "Сжатие контекста...",
"tokens": "токены"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/tr/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Bağlam Özetlendi",
"condensing": "Bağlam yoğunlaştırılıyor...",
"tokens": "token"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/vi/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "Ngữ cảnh đã tóm tắt",
"condensing": "Đang cô đọng ngữ cảnh...",
"tokens": "token"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/zh-CN/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "上下文已压缩",
"condensing": "正在压缩上下文...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
1 change: 1 addition & 0 deletions webview-ui/src/i18n/locales/zh-TW/chat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
},
"contextCondense": {
"title": "上下文已壓縮",
"condensing": "正在壓縮上下文...",
"tokens": "tokens"
},
"followUpSuggest": {
Expand Down
Loading