Skip to content

feat: Update Ollama UI to use text inputs #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Jul 17, 2025
Merged

feat: Update Ollama UI to use text inputs #5818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff38328
feat: update Ollama UI to use text inputs for model and dimensions
daniel-lxs Jul 17, 2025
c306e78
fix: add radix to parseInt and handle NaN cases
daniel-lxs Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 38 additions & 24 deletions webview-ui/src/components/chat/CodeIndexPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ const createValidationSchema = (provider: EmbedderProvider, t: any) => {
.min(1, t("settings:codeIndex.validation.ollamaBaseUrlRequired"))
.url(t("settings:codeIndex.validation.invalidOllamaUrl")),
codebaseIndexEmbedderModelId: z.string().min(1, t("settings:codeIndex.validation.modelIdRequired")),
codebaseIndexEmbedderModelDimension: z
.number()
.min(1, t("settings:codeIndex.validation.modelDimensionRequired"))
.optional(),
})

case "openai-compatible":
Expand Down Expand Up @@ -709,40 +713,50 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
<label className="text-sm font-medium">
{t("settings:codeIndex.modelLabel")}
</label>
<VSCodeDropdown
value={currentSettings.codebaseIndexEmbedderModelId}
onChange={(e: any) =>
<VSCodeTextField
value={currentSettings.codebaseIndexEmbedderModelId || ""}
onInput={(e: any) =>
updateSetting("codebaseIndexEmbedderModelId", e.target.value)
}
placeholder={t("settings:codeIndex.modelPlaceholder")}
className={cn("w-full", {
"border-red-500": formErrors.codebaseIndexEmbedderModelId,
})}>
<VSCodeOption value="" className="p-2">
{t("settings:codeIndex.selectModel")}
</VSCodeOption>
{getAvailableModels().map((modelId) => {
const model =
codebaseIndexModels?.[
currentSettings.codebaseIndexEmbedderProvider
]?.[modelId]
return (
<VSCodeOption key={modelId} value={modelId} className="p-2">
{modelId}{" "}
{model
? t("settings:codeIndex.modelDimensions", {
dimension: model.dimension,
})
: ""}
</VSCodeOption>
)
})}
</VSCodeDropdown>
/>
{formErrors.codebaseIndexEmbedderModelId && (
<p className="text-xs text-vscode-errorForeground mt-1 mb-0">
{formErrors.codebaseIndexEmbedderModelId}
</p>
)}
</div>

<div className="space-y-2">
<label className="text-sm font-medium">
{t("settings:codeIndex.modelDimensionLabel")}
</label>
<VSCodeTextField
value={
currentSettings.codebaseIndexEmbedderModelDimension?.toString() ||
""
}
onInput={(e: any) => {
const value = e.target.value
? parseInt(e.target.value, 10) || undefined
: undefined
updateSetting("codebaseIndexEmbedderModelDimension", value)
}}
placeholder={t("settings:codeIndex.modelDimensionPlaceholder")}
className={cn("w-full", {
"border-red-500":
formErrors.codebaseIndexEmbedderModelDimension,
})}
/>
{formErrors.codebaseIndexEmbedderModelDimension && (
<p className="text-xs text-vscode-errorForeground mt-1 mb-0">
{formErrors.codebaseIndexEmbedderModelDimension}
</p>
)}
</div>
</>
)}

Expand Down Expand Up @@ -835,7 +849,7 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
}
onInput={(e: any) => {
const value = e.target.value
? parseInt(e.target.value)
? parseInt(e.target.value, 10) || undefined
: undefined
updateSetting("codebaseIndexEmbedderModelDimension", value)
}}
Expand Down