fix: resolve global mode export not including rules files (#5834)

[hannesrudolph]

Description

Fixes #5834

This PR fixes an issue where exporting global modes did not include their associated rules files from the global ~/.roo directory. The export functionality was only checking for rules files in the workspace directory, missing rules files stored in the global configuration directory.

Changes Made

• Modified exportModeWithRules method in src/core/config/CustomModesManager.ts to determine the correct base directory based on the mode's source
• For global modes: Now uses getGlobalRooDirectory() to access ~/.roo
• For project modes: Continues to use the workspace directory
• Adjusted rules directory path construction:
  • Global modes: path.join(baseDir, 'rules-${slug}')
  • Project modes: path.join(baseDir, '.roo', 'rules-${slug}')
• Updated relative path calculation when reading rules files to handle the different directory structures

Testing

• All existing tests pass (44 tests)
• Manual testing completed:
  • Created a global mode with rules files in ~/.roo/rules-{mode-slug}/
  • Verified export now includes the rules files
  • Verified project mode export continues to work correctly
• The fix follows the same pattern as importModeWithRules which already correctly handles both global and project modes

Verification of Acceptance Criteria

• Global mode export now includes rules files from ~/.roo/rules-{slug}/ directory
• Project mode export continues to work correctly with rules from .roo/rules-{slug}/
• No breaking changes introduced

Checklist

• Code follows project style guidelines
• Self-review completed
• Comments added for complex logic
• Documentation updated (if needed)
• No breaking changes
• All tests pass
• Linting checks pass

---

Important

Fixes global mode export to include rules files from global ~/.roo directory in CustomModesManager.ts.

• Behavior:
  • Fixes exportModeWithRules in CustomModesManager.ts to include rules files from global ~/.roo directory for global modes.
  • Uses getGlobalRooDirectory() for global modes and workspace directory for project modes.
  • Adjusts path construction for rules directories based on mode source.
• Testing:
  • Adds tests in CustomModesManager.spec.ts for exporting global modes with and without rules.
  • Verifies export includes rules files from ~/.roo/rules-{slug}/ for global modes.
  • Ensures project mode export remains functional.

^{This description was created by for 00240ab. You can customize this summary. It will automatically update as commits are pushed.}

[Copilot]

Pull Request Overview

This PR fixes an issue where exporting global modes did not include their associated rules files by adjusting the base directory and path calculations for global versus project modes.

• Determines baseDir based on whether the mode is global or project
• Updates modeRulesDir path for global (~/.roo/rules-{slug}) and project (workspace/.roo/rules-{slug})
• Adjusts relative path calculation accordingly

Comments suppressed due to low confidence (1)

src/core/config/CustomModesManager.ts:691

• Add a unit test for exportModeWithRules covering a global mode with rules files in ~/.roo/rules-{slug} to ensure this new path logic is exercised programmatically.

			let baseDir: string

[Copilot]

[nitpick] There are multiple mode.source === "global" checks; consider extracting this into a single helper or variable to reduce duplication and improve readability.

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 00240ab.

Security Overview

• 🔎 Scanned files: 2 changed file(s)

Detected Code Changes

Change Type	Relevant files
Refactor	► CustomModesManager.ts     Extract helper methods and improve code organization     Enhance global mode handling ► CustomModesManager.spec.ts     Add comprehensive tests for global mode functionality ► api.ts     Update log file path handling ► CHANGELOG.md     Remove upcoming version entry ► package.json     Update version number

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

[daniel-lxs]

LGTM