fix: revert unrelated test changes in PR #5863 #5919
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error reporting - Add diagnosticsDelayMs setting (default: 2000ms) to allow linters time to process - Add diagnosticsEnabled setting to optionally disable diagnostic checking entirely - Update DiffViewProvider.saveChanges() to use configurable delay before checking diagnostics - Update all tool files (writeToFile, searchAndReplace, insertContent, applyDiff, multiApplyDiff) to pass diagnostic settings - Add comprehensive tests for new diagnostic functionality - Fixes issue where Go diagnostics errors were submitted to LLM before linter could clean up unused imports Resolves #5859
- Add diagnosticsDelayMs and diagnosticsEnabled to globalSettingsSchema - Include properties in ExtensionState Pick type - Add default values to EVALS_SETTINGS - Fix VSCode mock to include DiagnosticSeverity for tests - Resolves compilation errors in ClineProvider and webviewMessageHandler
- Add providerRef mock to insertContentTool and writeToFileTool tests - Update mocks to include diagnosticsEnabled and diagnosticsDelayMs settings - Fix test expectations to match new implementation with diagnostic configuration - Resolves failing unit tests for insertContentTool.spec.ts and writeToFileTool.spec.ts
- Remove diagnosticsDelayMs setting in favor of existing writeDelayMs - Add min(0) validation for writeDelayMs in global settings schema - Add error handling around delay function calls in DiffViewProvider - Create DEFAULT_WRITE_DELAY_MS constant (1000ms) to replace repeated defaults - Update all tool files to pass writeDelayMs instead of diagnosticsDelayMs - Remove diagnosticsDelayMs from webview message handlers and types - Update test files to use writeDelayMs instead of diagnosticsDelayMs This refactoring consolidates diagnostic delay functionality to use the existing writeDelayMs setting as requested in PR feedback.
- Fix DiffViewProvider test to expect correct default delay (1000ms instead of 2000ms) - Fix TypeScript type errors in ClineProvider test mock state object - Correct terminalPowershellCounter and terminalZdotdir types to boolean - Fix pinnedApiConfigs type from array to Record<string, boolean>
…nctionality - Reverted massive test data expansion in ClineProvider.spec.ts that added unrelated properties like terminal settings, API configs, and UI settings - Kept only the essential diagnosticsEnabled property for Go diagnostics feature - Restored original test structure and property organization - Reverted unrelated comment change in writeToFileTool.spec.ts - Preserved all core Go diagnostics functionality in other files This focuses the PR on its intended purpose: adding configurable diagnostic delay settings for Go development without unnecessary test complexity.
dosubot
bot
added
the
size:XL
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts unrelated changes found in PR #5863 while preserving the intended Go diagnostics functionality.
Problem
PR #5863 was intended to add configurable diagnostic delay settings for Go diagnostics, but it included significant unrelated changes to test files that expanded test complexity unnecessarily.
Changes Made
ClineProvider.spec.tsthat added unrelated properties:terminalOutputLineLimit,terminalShellIntegrationTimeout, etc.)currentApiConfigName,listApiConfigMeta, etc.)soundVolume,ttsSpeed,screenshotQuality, etc.)alwaysAllowModeSwitch,alwaysAllowSubtasks, etc.)diagnosticsEnabled: truepropertyDEFAULT_WRITE_DELAY_MSimportwriteToFileTool.spec.tsImpact
Files Changed
src/core/webview/__tests__/ClineProvider.spec.ts- Reverted unrelated test expansionsrc/core/tools/__tests__/writeToFileTool.spec.ts- Reverted unrelated comment changeAll other files from PR #5863 remain unchanged, preserving the core Go diagnostics functionality.
Fixes unrelated changes in PR #5863
Important
Reverts unrelated test changes from PR #5863 while preserving Go diagnostics functionality.
ClineProvider.spec.tsfor terminal, API, UI, and authorization settings.writeToFileTool.spec.ts.diagnosticsEnabled: trueandDEFAULT_WRITE_DELAY_MSimport.This description was created by
for b3cdcf0. You can customize this summary. It will automatically update as commits are pushed.