Skip to content

fix: hide Test ErrorBoundary button in production mode #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Jul 28, 2025
Merged

fix: hide Test ErrorBoundary button in production mode #6216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
186cb52
fix: hide Test ErrorBoundary button in production mode
roomote Jul 25, 2025
a0402df
fix: remove Test ErrorBoundary button completely and revert vite conf…
roomote Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 1 addition & 31 deletions webview-ui/src/components/settings/About.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { HTMLAttributes, useState } from "react"
import { HTMLAttributes } from "react"
import { useAppTranslation } from "@/i18n/TranslationContext"
import { Trans } from "react-i18next"
import { Info, Download, Upload, TriangleAlert } from "lucide-react"
Expand All @@ -22,33 +22,9 @@ type AboutProps = HTMLAttributes<HTMLDivElement> & {

export const About = ({ telemetrySetting, setTelemetrySetting, className, ...props }: AboutProps) => {
const { t } = useAppTranslation()
const [shouldThrowError, setShouldThrowError] = useState(false)

// Function to trigger error for testing ErrorBoundary
const triggerTestError = () => {
setShouldThrowError(true)
}

// Named function to make it easier to identify in stack traces
function throwTestError() {
// Intentionally cause a type error by accessing a property on undefined
const obj: any = undefined
obj.nonExistentMethod()
}

// Test component that throws an error when shouldThrow is true
const ErrorThrower = ({ shouldThrow = false }) => {
if (shouldThrow) {
// Use a named function to make it easier to identify in stack traces
throwTestError()
}
return null
}

return (
<div className={cn("flex flex-col gap-2", className)} {...props}>
{/* Test component that throws an error when shouldThrow is true */}
<ErrorThrower shouldThrow={shouldThrowError} />
<SectionHeader
description={
Package.sha
Expand Down Expand Up @@ -108,12 +84,6 @@ export const About = ({ telemetrySetting, setTelemetrySetting, className, ...pro
<TriangleAlert className="p-0.5" />
{t("settings:footer.settings.reset")}
</Button>

{/* Test button for ErrorBoundary - only visible in development */}
<Button variant="destructive" onClick={triggerTestError} className="w-auto">
<TriangleAlert className="p-0.5" />
Test ErrorBoundary
</Button>
</div>
</Section>
</div>
Expand Down