-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: Add Kimi K2 0905 model to Groq, Moonshot, and Fireworks providers #7693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? The PR description mentions adding Kimi K2 0905 model to existing providers, but this introduces an entirely new 'anthropic-compatible' provider. This is a significant architectural change that should be mentioned in the PR title and description. Could we consider splitting this into a separate PR to keep changes focused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class appears to be nearly identical to AnthropicHandler. Could we reduce code duplication by extending AnthropicHandler instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The getModel() method doesn't handle the case when a user provides a custom model ID that isn't in the anthropicModels list. Should we add validation or fallback logic here to handle custom models properly with anthropicCustomModelInfo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model dropdown is hidden for anthropic-compatible provider, but there's no alternative way to select from the predefined anthropicModels list. Users can only manually type model IDs. Is this the intended UX? Perhaps we should show the dropdown but also allow custom input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings should use the translation system for consistency:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label should also use the translation system:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label should use the translation system:
- Added Kimi K2 0905 model with 256K context window - Updated default models to use the new version - Added prompt caching support where applicable - Updated tests to reflect new model configurations
7bc631f to
b7f77c7
Compare
Summary
Adds the new Kimi K2 0905 model version to multiple providers with extended context window support.
Changes
Improvements
All tests updated and passing.
Important
Adds Kimi K2 0905 model to Groq, Moonshot, and Fireworks providers with extended context window and prompt caching support.
fireworks.ts,groq.ts, andmoonshot.tswith extended context window to 256K tokens.fireworks.ts,groq.ts, andmoonshot.ts.moonshot.spec.tsto reflect new model'smaxTokensandcontextWindowvalues.supportsPromptCacheis true for Kimi K2 0905 model in tests.This description was created by
for b7f77c7. You can customize this summary. It will automatically update as commits are pushed.