Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Sep 5, 2025

Summary

Adds the new Kimi K2 0905 model version to multiple providers with extended context window support.

Changes

  • Added Kimi K2 0905 model to Groq, Moonshot, and Fireworks providers
  • Updated default models to use the new Kimi K2 0905 version
  • Extended context window from 128K to 256K tokens
  • Added prompt caching support where applicable

Improvements

  • Better agentic coding with improved accuracy and generalization
  • Enhanced frontend coding capabilities
  • Extended context length for better long-horizon support

All tests updated and passing.


Important

Adds Kimi K2 0905 model to Groq, Moonshot, and Fireworks providers with extended context window and prompt caching support.

  • Behavior:
    • Adds Kimi K2 0905 model to fireworks.ts, groq.ts, and moonshot.ts with extended context window to 256K tokens.
    • Updates default model to Kimi K2 0905 in fireworks.ts, groq.ts, and moonshot.ts.
    • Adds prompt caching support to Kimi K2 0905 model.
  • Tests:
    • Updates moonshot.spec.ts to reflect new model's maxTokens and contextWindow values.
    • Ensures supportsPromptCache is true for Kimi K2 0905 model in tests.

This description was created by Ellipsis for b7f77c7. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Sep 5, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 5, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? The PR description mentions adding Kimi K2 0905 model to existing providers, but this introduces an entirely new 'anthropic-compatible' provider. This is a significant architectural change that should be mentioned in the PR title and description. Could we consider splitting this into a separate PR to keep changes focused?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class appears to be nearly identical to AnthropicHandler. Could we reduce code duplication by extending AnthropicHandler instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getModel() method doesn't handle the case when a user provides a custom model ID that isn't in the anthropicModels list. Should we add validation or fallback logic here to handle custom models properly with anthropicCustomModelInfo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model dropdown is hidden for anthropic-compatible provider, but there's no alternative way to select from the predefined anthropicModels list. Users can only manually type model IDs. Is this the intended UX? Perhaps we should show the dropdown but also allow custom input?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings should use the translation system for consistency:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label should also use the translation system:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label should use the translation system:

- Added Kimi K2 0905 model with 256K context window
- Updated default models to use the new version
- Added prompt caching support where applicable
- Updated tests to reflect new model configurations
@daniel-lxs daniel-lxs force-pushed the feat/add-kimi-k2-0905-model branch from 7bc631f to b7f77c7 Compare September 5, 2025 03:51
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2025
@mrubens mrubens merged commit 4ad1a26 into main Sep 5, 2025
15 checks passed
@mrubens mrubens deleted the feat/add-kimi-k2-0905-model branch September 5, 2025 03:57
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 5, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants