-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: replace cloud waitlist ad with direct Cloud link in navigation #7742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replaced the "Roo Code Cloud is coming - Sign up" promotional banner with a simple "Cloud" link - Link now points directly to https://app.roocode.com - Kept /cloud-waitlist redirect for backward compatibility with the extension - Updated both desktop and mobile navigation menus
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-roaugk58u-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own code because apparently I trust no one, not even myself.
| </div> | ||
| </div> | ||
| <a | ||
| href="https://app.roocode.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding the Cloud URL to the EXTERNAL_LINKS constant for consistency with other external links. We could add:
| href="https://app.roocode.com" | |
| href={EXTERNAL_LINKS.CLOUD} |
After adding CLOUD: "https://app.roocode.com" to the constants file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote-agent good catch, can you add this to the constants file?
| Community | ||
| </a> | ||
| <a | ||
| href="https://app.roocode.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion here - consider using EXTERNAL_LINKS.CLOUD instead of hardcoding the URL for better maintainability.
| permanent: true, | ||
| }, | ||
| // Redirect cloud waitlist to Notion page | ||
| // Redirect cloud waitlist to Notion page (kept for extension compatibility) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that we're keeping this for backward compatibility! Is there a timeline for when this redirect might be removed, or should it remain indefinitely for extension users?
|
Hi @mrubens! I see the hardcoded URL "https://app.roocode.com" in nav-bar.tsx. I'll move it to the constants file right away. Working on it now! |
- Added CLOUD_APP constant to EXTERNAL_LINKS in constants.ts - Updated nav-bar.tsx to use EXTERNAL_LINKS.CLOUD_APP instead of hardcoded URL - Improves maintainability by centralizing external URLs
|
Done! ✅ I've moved the hardcoded
All CI checks have passed successfully. The changes are ready for review! |
Per Slack request: Replace the ad for the cloud waitlist in the nav with just a link to Cloud (https://app.roocode.com)
Changes
Testing
Screenshots
The promotional banner has been replaced with a clean "Cloud" link that matches the style of other navigation items.
Important
Replaced cloud waitlist ad with direct Cloud link in navigation and updated constants and redirects for compatibility.
nav-bar.tsx.https://app.roocode.com.CLOUD_APPtoEXTERNAL_LINKSinconstants.ts./cloud-waitlistredirect innext.config.tsfor backward compatibility.This description was created by
for 2e09bf3. You can customize this summary. It will automatically update as commits are pushed.