Skip to content

fix: resolve context menu z-index issue by keeping text area in fixed position #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel-lxs wants to merge 4 commits into from
Closed

fix: resolve context menu z-index issue by keeping text area in fixed position #7831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08b8365
feat: improve edit message overlay positioning and interaction
daniel-lxs Sep 9, 2025
48216d3
feat: add draft persistence for chat input during message editing
daniel-lxs Sep 10, 2025
36a46de
fix: preserve forwardRef in ChatView for ref compatibility
daniel-lxs Sep 10, 2025
c1332c5
chore: clean up unnecessary comment in handleBeginEdit
daniel-lxs Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions webview-ui/src/components/chat/ChatRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ interface ChatRowProps {
onFollowUpUnmount?: () => void
isFollowUpAnswered?: boolean
editable?: boolean
onBeginEdit?: (message: ClineMessage) => void
}

// eslint-disable-next-line @typescript-eslint/no-empty-object-type
Expand Down Expand Up @@ -113,6 +114,7 @@ export const ChatRowContent = ({
onBatchFileResponse,
isFollowUpAnswered,
editable,
onBeginEdit,
}: ChatRowContentProps) => {
const { t } = useTranslation()

Expand Down Expand Up @@ -146,13 +148,15 @@ export const ChatRowContent = ({

// Handle edit button click
const handleEditClick = useCallback(() => {
if (onBeginEdit) {
onBeginEdit(message)
return
}
setIsEditing(true)
setEditedContent(message.text || "")
setEditImages(message.images || [])
setEditMode(mode || "code")
// Edit mode is now handled entirely in the frontend
// No need to notify the backend
}, [message.text, message.images, mode])
}, [onBeginEdit, message, mode])

// Handle cancel edit
const handleCancelEdit = useCallback(() => {
Expand Down
Loading
Loading