Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Sep 15, 2025

Summary

This PR repositions the Add Image button to improve the UI layout of the ChatTextArea component based on user feedback.

Changes

  • Moved Add Image button: Relocated from outside the text area to inside (top-right corner)
  • Repositioned Enhance Prompt button: Moved to be right above the Send button
  • Improved button layout: Arranged buttons in a vertical flex layout for better space utilization

Visual Changes

The button layout has been reorganized:

  • Add Image button is now in the top-right corner inside the text area
  • Enhance Prompt and Send buttons are stacked vertically in the bottom-right corner
  • Cancel button (in edit mode) remains with the Send button


Technical Details

  • All existing functionality preserved (disabled states, onClick handlers, tooltips)
  • Maintained consistent styling with existing Tailwind CSS classes
  • No changes to button behavior or accessibility features
  • Button opacity and transition animations remain unchanged

Testing

  • Verified Add Image button works correctly in new position
  • Tested Enhance Prompt functionality
  • Confirmed Send button behavior unchanged
  • Checked edit mode with Cancel button
  • Tested responsive behavior and hover states

Related

Based on Slack feedback requesting improved button positioning within the ChatTextArea component.


Important

Repositioned Add Image and Enhance Prompt buttons in ChatTextArea for improved UI layout and adjusted button size in IndexingStatusBadge.

  • UI Changes in ChatTextArea.tsx:
    • Moved Add Image button inside the text area to the top-right corner.
    • Repositioned Enhance Prompt button above the Send button.
    • Arranged buttons in a vertical flex layout for better space utilization.
  • Styling Adjustments:
    • Increased minimum height of text area from 90px to 94px.
    • Adjusted padding and positioning for button layout.
  • IndexingStatusBadge.tsx:
    • Reduced button size from 7x7 to 5x5 in IndexingStatusBadge component.

This description was created by Ellipsis for b47dc0c. You can customize this summary. It will automatically update as commits are pushed.

- Moved Add Image button from bottom toolbar to top-right inside text area
- Repositioned Enhance Prompt button to be above Send button (bottom-right)
- Both buttons now follow similar positioning pattern as Send button
- Maintains consistent button styling and transitions
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my own code and found several issues I should have caught before submitting.

<button
aria-label={t("chat:addImages")}
disabled={shouldDisableImages}
onClick={!shouldDisableImages ? onSelectImages : undefined}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant disabled state handling intentional? The disabled prop is set to shouldDisableImages, but the onClick handler also checks the same condition. Could we simplify this to:

Suggested change
onClick={!shouldDisableImages ? onSelectImages : undefined}
onClick={onSelectImages}

and let the disabled prop handle preventing clicks?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 15, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Sep 15, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 15, 2025
mubeen-zulfiqar and others added 10 commits September 16, 2025 10:58
…ability (#7988)

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Bruno Bergher <me@brunobergher.com>
Co-authored-by: Mubeen Zulfiqar <mubeen_zulfiqar@yahoo.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.9.0 to 1.12.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.9.0...v1.12.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.12.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
* main:
  CONTRIBUTING.md tweaks and issue template rewrite (#8014)
  fix: handle ByteString conversion errors in OpenAI embedders (#8008)
  feat: add keyboard shortcut for "Add to Context" action (#7908)
  Fix context menu is obscured when edit message. (#7951)
  chore(deps): bump axios from 1.9.0 to 1.12.0 (#7963)
  Add Z.ai coding plan support (#8003)
  feat: Move slash commands to Settings tab with gear icon for discoverability (#7988)
  fix: corrected C# tree-sitter query (#7813)
@brunobergher brunobergher marked this pull request as ready for review September 16, 2025 10:11
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 16, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 16, 2025
@mrubens mrubens merged commit c987417 into main Sep 16, 2025
21 of 23 checks passed
@mrubens mrubens deleted the feature/move-add-image-button-inside-textarea branch September 16, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Draft / In Progress size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants