-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: Reposition Add Image button inside ChatTextArea #7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Moved Add Image button from bottom toolbar to top-right inside text area - Repositioned Enhance Prompt button to be above Send button (bottom-right) - Both buttons now follow similar positioning pattern as Send button - Maintains consistent button styling and transitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed my own code and found several issues I should have caught before submitting.
| <button | ||
| aria-label={t("chat:addImages")} | ||
| disabled={shouldDisableImages} | ||
| onClick={!shouldDisableImages ? onSelectImages : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this redundant disabled state handling intentional? The disabled prop is set to shouldDisableImages, but the onClick handler also checks the same condition. Could we simplify this to:
| onClick={!shouldDisableImages ? onSelectImages : undefined} | |
| onClick={onSelectImages} |
and let the disabled prop handle preventing clicks?
…ability (#7988) Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: Bruno Bergher <me@brunobergher.com> Co-authored-by: Mubeen Zulfiqar <mubeen_zulfiqar@yahoo.com> Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.9.0 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.9.0...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com> Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
* main: CONTRIBUTING.md tweaks and issue template rewrite (#8014) fix: handle ByteString conversion errors in OpenAI embedders (#8008) feat: add keyboard shortcut for "Add to Context" action (#7908) Fix context menu is obscured when edit message. (#7951) chore(deps): bump axios from 1.9.0 to 1.12.0 (#7963) Add Z.ai coding plan support (#8003) feat: Move slash commands to Settings tab with gear icon for discoverability (#7988) fix: corrected C# tree-sitter query (#7813)
Summary
This PR repositions the Add Image button to improve the UI layout of the ChatTextArea component based on user feedback.
Changes
Visual Changes
The button layout has been reorganized:
Technical Details
Testing
Related
Based on Slack feedback requesting improved button positioning within the ChatTextArea component.
Important
Repositioned Add Image and Enhance Prompt buttons in
ChatTextAreafor improved UI layout and adjusted button size inIndexingStatusBadge.ChatTextArea.tsx:IndexingStatusBadge.tsx:IndexingStatusBadgecomponent.This description was created by
for b47dc0c. You can customize this summary. It will automatically update as commits are pushed.