Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Sep 19, 2025

Important

Add roo/code-supernova model to Roo provider and update shouldUseSingleFileRead to include it.

  • Models:
    • Add roo/code-supernova to RooModelId in roo.ts.
    • Define roo/code-supernova in rooModels with maxTokens, contextWindow, supportsImages, supportsPromptCache, inputPrice, outputPrice, and description.
  • Functions:
    • Update shouldUseSingleFileRead() in single-file-read-models.ts to include code-supernova.

This description was created by Ellipsis for 7eb84b0. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the new Supernova model! I've reviewed the changes and found several areas that need attention before merging. The main concerns are the missing PR description, lack of test coverage for the new model, and some questions about the model's capabilities.

@roomote
Copy link
Contributor

roomote bot commented Sep 19, 2025

Additional Review Notes

Critical Issues:

  1. Missing PR Description: Please add a description to this PR explaining what the Supernova model is and why it's being added. This helps reviewers and future maintainers understand the context.

  2. Missing Test Coverage: The test file src/api/providers/__tests__/roo.spec.ts should be updated to include explicit test cases for the new "roo/code-supernova" model. While the existing test at lines 343-353 iterates through all models, we should add specific tests to verify the new model's unique capabilities (especially image support).

Suggestions:

  • Consider updating any relevant documentation or README files to mention the new model option
  • If this is a draft PR for testing purposes, that's fine, but please mark it as ready for review once these issues are addressed

Looking forward to seeing this new model in action! 🚀

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 19, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Sep 19, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Sep 19, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Sep 19, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
@cte cte marked this pull request as ready for review September 19, 2025 20:31
@cte cte requested a review from jr as a code owner September 19, 2025 20:31
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 19, 2025
@cte cte merged commit ac4eda9 into main Sep 19, 2025
19 checks passed
@cte cte deleted the supernova branch September 19, 2025 20:31
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 19, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants