-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Bare metal evals fixes #8224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare metal evals fixes #8224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found critical issues that need attention before merging.
|
@cte I see the memory leak issue in the RooHandler class. I will implement the suggested fix to properly clean up the event listener. Working on it now. |
- Add private authStateListener property to store listener reference - Store listener function reference for proper cleanup - Implement dispose() method to remove event listener - Fix API key issue by using cloudService reference instead of CloudService.instance - Update tests to include on/off methods in CloudService mock This prevents memory leaks when multiple RooHandler instances are created and ensures proper cleanup of event listeners.
|
@cte The memory leak has been fixed! Changes Made:
Test Results:
The implementation follows the suggested pattern exactly and prevents memory leaks when multiple RooHandler instances are created. The dispose method ensures proper cleanup of event listeners. |
Important
Handle session token changes in
RooHandlerand set evals web app to run on port 3446.RooHandlerinroo.tsby addingauthStateListenerto update the OpenAI client on auth state changes.dispose()inRooHandlerremovesauthStateListener.roo.spec.tsto cover new session token handling logic.package.json,README.md, anddocker-compose.yml.extension.ts.This description was created by
for 22645a9. You can customize this summary. It will automatically update as commits are pushed.