-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ux: Collapse thinking blocks by default (but control all of them with a keyboard shortcut) #8254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add collapsible UI with chevron icon that shows on hover - Default to collapsed state showing only last 2 lines - Move elapsed time counter next to thinking label - Add smooth transitions and gradient mask for collapsed state
- Add reasoningBlockCollapsed setting to global state - Add backend message handler for persisting collapsed state - Add keyboard shortcut (Ctrl/Cmd+Shift+T) to toggle all reasoning blocks - Default to collapsed state for better UX
… with Thinking blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found issues that need attention.
| const { reasoningBlockCollapsed } = useExtensionState() | ||
|
|
||
| // Initialize collapsed state based on global setting (default to collapsed) | ||
| const [isCollapsed, setIsCollapsed] = useState(reasoningBlockCollapsed !== false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent default state initialization: This uses which is a double negative pattern. Since line 285 defaults to , this could be simplified to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the gist of it.
…quireTodos - Added 'Toggle Thinking Blocks' translation to all 17 language files - Added 'Require todos parameter' translation to all 17 language files - Ensures consistency across all supported locales
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
| }, | ||
| "reasoning": { | ||
| "thinking": "Pensando", | ||
| "seconds": "{{count}}s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
Roo is smart, but thinks out loud too loud.
We've been experiencing first hand (and hearing feeback) that the expanded-by-default thinking blocks are too much.
This PR:
Test Procedure
Important
Collapse thinking blocks by default with a new UI setting and keyboard shortcut for toggling.
ReasoningBlockinReasoningBlock.tsxnow collapses by default and can be toggled with a new keyboard shortcut (Cmd/Ctrl + Shift + Alt + T).UISettings.tsxto control the default collapse state of thinking blocks.reasoningBlockCollapsedtoglobal-settings.tsandClineProvider.tsto manage the default collapse state.SettingsView.tsxto include the new UI setting for collapsing thinking blocks.UISettings.spec.tsxto test the new UI setting for collapsing thinking blocks.This description was created by
for 285ced2. You can customize this summary. It will automatically update as commits are pushed.