Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Sep 23, 2025

Important

Adds "followup" to interactiveAsks in message.ts, marking it as requiring user interaction.

  • Behavior:
    • Adds "followup" to interactiveAsks array in message.ts, classifying it as requiring user interaction.

This description was created by Ellipsis for bd27049. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners September 23, 2025 17:16
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Sep 23, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is logically correct - follow-up questions do require user interaction, so they should be in the interactiveAsks array. This will ensure proper state management and likely improve push notifications or other UI feedback when the assistant asks follow-up questions.

However, there are some important considerations that should be addressed.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2025
@mrubens mrubens merged commit 19c3606 into main Sep 23, 2025
22 of 23 checks passed
@mrubens mrubens deleted the cte/input-required-push-notifications branch September 23, 2025 17:47
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 23, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants