fix: restore MCP auto-approval behavior to approve all tools when enabled

[roomote]

This PR attempts to address Issue #9190. Feedback and guidance are welcome.

Problem

After the recent refactoring that moved auto-approval logic from ChatView to Task (#9157), the MCP auto-approval behavior changed. Previously, when alwaysAllowMcp was enabled, ALL MCP tools would be auto-approved. After the refactor, both alwaysAllowMcp AND the individual tool alwaysAllow flag had to be true, which broke the expected behavior.

Solution

Changed the logic from AND to OR condition:

• When alwaysAllowMcp is enabled → auto-approve all MCP tools
• When a specific tool has alwaysAllow flag → auto-approve that specific tool
• Either condition can trigger auto-approval independently

Changes

• Modified src/core/auto-approval/index.ts to use OR logic instead of AND
• Added comprehensive test coverage in src/core/auto-approval/__tests__/index.spec.ts

Testing

• ✅ All new tests pass
• ✅ All existing tests pass
• ✅ Linting passes
• ✅ Type checking passes

Fixes #9190

---

Important

Fixes MCP auto-approval logic to approve tools if either global or individual flags are set, with added tests.

• Behavior:
  • Changes MCP auto-approval logic in checkAutoApproval() in index.ts to use OR condition.
  • Auto-approves all MCP tools if alwaysAllowMcp is true or if the tool's alwaysAllow flag is true.
• Testing:
  • Adds tests in index.spec.ts to cover scenarios for MCP tool and resource auto-approval.
  • Tests handle cases with missing or invalid JSON, and when neither flag is set.
• Misc:
  • Fixes issue [BUG] auto approuve no more working #9190.

^{This description was created by for 00102b6. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. The changes look good - the fix correctly restores the MCP auto-approval behavior by changing from AND to OR logic. When alwaysAllowMcp is enabled, all MCP tools will be auto-approved as expected. Individual tools can still be approved via their alwaysAllow flag. The test coverage is comprehensive and validates all scenarios.

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[nonsleepr]

Tested the fix, it's bad. Auto-approves even if the tool is configured NOT to auto-approve.