Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/types/src/provider-settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ const moonshotSchema = apiModelIdProviderModelSchema.extend({

const minimaxSchema = apiModelIdProviderModelSchema.extend({
minimaxBaseUrl: z
.union([z.literal("https://api.minimax.io/v1"), z.literal("https://api.minimaxi.com/v1")])
.union([z.literal("https://api.minimax.io/anthropic"), z.literal("https://api.minimaxi.com/anthropic")])
.optional(),
minimaxApiKey: z.string().optional(),
})
Expand Down
3 changes: 1 addition & 2 deletions packages/types/src/providers/minimax.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export const minimaxModels = {
outputPrice: 1.2,
cacheWritesPrice: 0.375,
cacheReadsPrice: 0.03,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preserveReasoning property was removed from both MiniMax model definitions, but the code in Task.ts (line 2425) still checks this.api.getModel().info.preserveReasoning to determine whether to preserve reasoning in the API history. Since MiniMax models no longer have this property, reasoning will not be preserved. If reasoning preservation is still desired for MiniMax (which now uses the Anthropic format and supports thinking blocks), you should either restore preserveReasoning: true or update the Task.ts logic to handle MiniMax's reasoning differently.

Fix it with Roo Code or mention @roomote and request a fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ant_thinking and ant_redacted_thinking block types with the Anthropic API to preserve reasoning.

preserveReasoning: true,
description:
"MiniMax M2, a model born for Agents and code, featuring Top-tier Coding Capabilities, Powerful Agentic Performance, and Ultimate Cost-Effectiveness & Speed.",
},
Expand All @@ -30,10 +29,10 @@ export const minimaxModels = {
outputPrice: 1.2,
cacheWritesPrice: 0.375,
cacheReadsPrice: 0.03,
preserveReasoning: true,
description:
"MiniMax M2 Stable (High Concurrency, Commercial Use), a model born for Agents and code, featuring Top-tier Coding Capabilities, Powerful Agentic Performance, and Ultimate Cost-Effectiveness & Speed.",
},
} as const satisfies Record<string, ModelInfo>

export const MINIMAX_DEFAULT_TEMPERATURE = 1.0
export const MINIMAX_DEFAULT_MAX_TOKENS = 16384
2 changes: 1 addition & 1 deletion src/api/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import {
FeatherlessHandler,
VercelAiGatewayHandler,
DeepInfraHandler,
MiniMaxHandler,
MiniMaxAnthropicHandler as MiniMaxHandler,
} from "./providers"
import { NativeOllamaHandler } from "./providers/native-ollama"

Expand Down
Loading