Skip to content

Conversation

@KevinZhao
Copy link
Contributor

@KevinZhao KevinZhao commented Nov 13, 2025

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Remove legacy Claude 2 series and Titan embedding models from AWS Bedrock provider and update related tests.

  • Behavior:
    • Removed legacy models anthropic.claude-2-1-v1:0, anthropic.claude-2-0-v1:0, anthropic.claude-instant-v1:0, amazon.titan-text-embeddings-v1:0, and amazon.titan-text-embeddings-v2:0 from bedrock.ts.
    • Updated bedrockModels in bedrock.ts to exclude removed models.
  • Tests:
    • Updated test cases in provider-settings.test.ts, bedrock-invokedModelId.spec.ts, Task.spec.ts, ClineProvider.apiHandlerRebuild.spec.ts, and ApiConfigSelector.spec.tsx to remove references to legacy models and use updated model IDs.
  • Misc:
    • Adjusted model IDs in various test files to ensure compatibility with the updated model list.

This description was created by Ellipsis for 6d86f4e. You can customize this summary. It will automatically update as commits are pushed.

Zhao and others added 2 commits November 13, 2025 14:02
…Bedrock

Remove 5 deprecated/incompatible models from Bedrock model list:
- Claude 2.1, 2.0, and Claude Instant (no longer supported by AWS)
- Titan Text Embeddings v1 and v2 (embedding-only, not suitable for chat/code tasks)

Update all test files to use Claude 4.5 Sonnet (anthropic.claude-sonnet-4-5-20250929-v1:0),
the current Bedrock default model, ensuring consistency across the test suite.

Updated files:
- Model definitions: packages/types/src/providers/bedrock.ts
- Test files: 6 test files updated with new model references
- Documentation: Updated ARN examples in bedrock.ts comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
…ck-models

refactor: remove deprecated Claude 2 and Titan embedding models from Bedrock
@KevinZhao KevinZhao requested review from cte, jr and mrubens as code owners November 13, 2025 06:08
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 13, 2025

Rooviewer Clock   See task on Roo Cloud

Review found 1 issue after the merge with main.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 13, 2025
@KevinZhao
Copy link
Contributor Author

As this models can not be used, it affecting user experience.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 10, 2025
outputPrice: 1.8,
description: "Qwen3 Coder 480B (MoE model with 35B active parameters)",
},
} as const satisfies Record<string, ModelInfo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge with main appears to have incorrectly removed 4 models that were recently added in PR #9905: moonshot.kimi-k2-thinking, minimax.minimax-m2, qwen.qwen3-next-80b-a3b, and qwen.qwen3-coder-480b-a35b-v1:0. These models exist in main but are missing from this branch. This looks like a merge conflict resolution error - the PR should only remove the legacy Claude 2 and Titan embedding models, not these newly added models.

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants