feat: implement dynamic tool protocol resolution with proper precedence hierarchy

packages/types/src/model.ts

@@ -109,6 +109,8 @@ export const modelInfoSchema = z.object({
 	isFree: z.boolean().optional(),
 	// Flag to indicate if the model supports native tool calling (OpenAI-style function calling)
 	supportsNativeTools: z.boolean().optional(),
+	// Default tool protocol preferred by this model (if not specified, falls back to capability/provider defaults)
+	defaultToolProtocol: z.enum(["xml", "native"]).optional(),
 	/**
 	 * Service tiers with pricing information.
 	 * Each tier can have a name (for OpenAI service tiers) and pricing overrides.

packages/types/src/provider-settings.ts

@@ -182,6 +182,9 @@ const baseProviderSettingsSchema = z.object({
 
 	// Model verbosity.
 	verbosity: verbosityLevelsSchema.optional(),
+
+	// Tool protocol override for this profile.
+	toolProtocol: z.enum(["xml", "native"]).optional(),
 })
 
 // Several of the providers share common model config properties.

packages/types/src/providers/roo.ts

@@ -1,6 +1,7 @@
 import { z } from "zod"
 
 import type { ModelInfo } from "../model.js"
+import { TOOL_PROTOCOL } from "../tool.js"
 
 /**
  * Roo Code Cloud is a dynamic provider - models are loaded from the /v1/models API endpoint.
@@ -14,6 +15,38 @@ export const rooDefaultModelId = "xai/grok-code-fast-1"
  */
 export const rooModels = {} as const satisfies Record<string, ModelInfo>
 
+/**
+ * Model-specific defaults for Roo provider models.
+ * These defaults are merged with dynamically fetched model data.
+ *
+ * Use this to configure model-specific settings like defaultToolProtocol.
+ *
+ * Example usage:
+ * ```typescript
+ * export const rooModelDefaults: Record<string, Partial<ModelInfo>> = {
+ *   "anthropic/claude-3-5-sonnet-20241022": {
+ *     defaultToolProtocol: "xml",
+ *   },
+ *   "openai/gpt-4o": {
+ *     defaultToolProtocol: "native",
+ *   },
+ *   "xai/grok-code-fast-1": {
+ *     defaultToolProtocol: "native",
+ *   },
+ * }
+ * ```
+ */
+export const rooModelDefaults: Record<string, Partial<ModelInfo>> = {
+	// Add model-specific defaults below.
+	// You can configure defaultToolProtocol and other ModelInfo fields for specific model IDs.
+	"anthropic/claude-haiku-4.5": {
+		defaultToolProtocol: TOOL_PROTOCOL.NATIVE,
+	},
+	"minimax/minimax-m2:free": {
+		defaultToolProtocol: TOOL_PROTOCOL.NATIVE,
+	},
+}
+
 /**
  * Roo Code Cloud API response schemas
  */

src/api/providers/fetchers/roo.ts

@@ -1,4 +1,4 @@
-import { RooModelsResponseSchema } from "@roo-code/types"
+import { RooModelsResponseSchema, rooModelDefaults } from "@roo-code/types"
 
 import type { ModelRecord } from "../../../shared/api"
 import { parseApiPrice } from "../../../shared/cost"
@@ -101,7 +101,8 @@ export async function getRooModels(baseUrl: string, apiKey?: string): Promise<Mo
 				const cacheReadPrice = pricing.input_cache_read ? parseApiPrice(pricing.input_cache_read) : undefined
 				const cacheWritePrice = pricing.input_cache_write ? parseApiPrice(pricing.input_cache_write) : undefined
 
-				models[modelId] = {
+				// Build the base model info from API response
+				const baseModelInfo = {
 					maxTokens,
 					contextWindow,
 					supportsImages,
@@ -117,6 +118,11 @@ export async function getRooModels(baseUrl: string, apiKey?: string): Promise<Mo
 					deprecated: model.deprecated || false,
 					isFree: tags.includes("free"),
 				}
+
+				// Merge with model-specific defaults if they exist
+				// Defaults take precedence over dynamically fetched data for specified fields
+				const modelDefaults = rooModelDefaults[modelId]
+				models[modelId] = modelDefaults ? { ...baseModelInfo, ...modelDefaults } : baseModelInfo
 			}
 
 			return models

src/api/providers/roo.ts

@@ -1,7 +1,7 @@
 import { Anthropic } from "@anthropic-ai/sdk"
 import OpenAI from "openai"
 
-import { rooDefaultModelId, getApiProtocol } from "@roo-code/types"
+import { rooDefaultModelId, rooModelDefaults, getApiProtocol } from "@roo-code/types"
 import { CloudService } from "@roo-code/cloud"
 
 import type { ApiHandlerOptions, ModelRecord } from "../../shared/api"
@@ -274,18 +274,26 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
 		}
 
 		// Return the requested model ID even if not found, with fallback info.
+		// Check if there are model-specific defaults configured
+		const baseModelInfo = {
+			maxTokens: 16_384,
+			contextWindow: 262_144,
+			supportsImages: false,
+			supportsReasoningEffort: false,
+			supportsPromptCache: true,
+			supportsNativeTools: false,
+			inputPrice: 0,
+			outputPrice: 0,
+			isFree: false,
+		}
+
+		// Merge with model-specific defaults if they exist
+		const modelDefaults = rooModelDefaults[modelId]
+		const fallbackInfo = modelDefaults ? { ...baseModelInfo, ...modelDefaults } : baseModelInfo
+
 		return {
 			id: modelId,
-			info: {
-				maxTokens: 16_384,
-				contextWindow: 262_144,
-				supportsImages: false,
-				supportsReasoningEffort: false,
-				supportsPromptCache: true,
-				supportsNativeTools: false,
-				inputPrice: 0,
-				outputPrice: 0,
-			},
+			info: fallbackInfo,
 		}
 	}
 }

src/core/assistant-message/presentAssistantMessage.ts

@@ -39,7 +39,7 @@ import { codebaseSearchTool } from "../tools/CodebaseSearchTool"
 import { experiments, EXPERIMENT_IDS } from "../../shared/experiments"
 import { applyDiffTool as applyDiffToolClass } from "../tools/ApplyDiffTool"
 import { isNativeProtocol } from "@roo-code/types"
-import { getToolProtocolFromSettings } from "../../utils/toolProtocol"
+import { resolveToolProtocol } from "../../utils/resolveToolProtocol"
 
 /**
  * Processes and presents assistant message content to the user interface.
@@ -282,7 +282,12 @@ export async function presentAssistantMessage(cline: Task) {
 
 			const pushToolResult = (content: ToolResponse) => {
 				// Check if we're using native tool protocol
-				const isNative = isNativeProtocol(getToolProtocolFromSettings())
+				const toolProtocol = resolveToolProtocol(
+					cline.apiConfiguration,
+					cline.api.getModel().info,
+					cline.apiConfiguration.apiProvider,
+				)
+				const isNative = isNativeProtocol(toolProtocol)
 
 				// Get the tool call ID if this is a native tool call
 				const toolCallId = (block as any).id
@@ -513,7 +518,12 @@ export async function presentAssistantMessage(cline: Task) {
 					await checkpointSaveAndMark(cline)
 
 					// Check if native protocol is enabled - if so, always use single-file class-based tool
-					if (isNativeProtocol(getToolProtocolFromSettings())) {
+					const applyDiffToolProtocol = resolveToolProtocol(
+						cline.apiConfiguration,
+						cline.api.getModel().info,
+						cline.apiConfiguration.apiProvider,
+					)
+					if (isNativeProtocol(applyDiffToolProtocol)) {
 						await applyDiffToolClass.handle(cline, block as ToolUse<"apply_diff">, {
 							askApproval,
 							handleError,

src/core/prompts/sections/markdown-formatting.ts

@@ -3,5 +3,5 @@ export function markdownFormattingSection(): string {
 
 MARKDOWN RULES
 
-ALL responses MUST show ANY \`language construct\` OR filename reference as clickable, exactly as [\`filename OR language.declaration()\`](relative/file/path.ext:line); line is required for \`syntax\` and optional for filename links. This applies to ALL markdown responses and ALSO those in <attempt_completion>`
+ALL responses MUST show ANY \`language construct\` OR filename reference as clickable, exactly as [\`filename OR language.declaration()\`](relative/file/path.ext:line); line is required for \`syntax\` and optional for filename links. This applies to ALL markdown responses and ALSO those in attempt_completion`
 }