Skip to content

fix: prevent infinite loop when attempt_completion succeeds #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 2 commits into from
Nov 17, 2025
Merged

fix: prevent infinite loop when attempt_completion succeeds #9325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8fb4d8
fix: prevent infinite loop when attempt_completion succeeds
daniel-lxs Nov 17, 2025
364671d
fix: remove comment to prevent infinite loop continuation in attempt_…
daniel-lxs Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/tools/AttemptCompletionTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ export class AttemptCompletionTool extends BaseTool<"attempt_completion"> {
const { response, text, images } = await task.ask("completion_result", "", false)

if (response === "yesButtonClicked") {
pushToolResult("")
return
}

// User provided feedback - push tool result to continue the conversation
await task.say("user_feedback", text ?? "", images)

const feedbackText = `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`
Expand Down
Loading