Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 18, 2025

Important

Enable native tool calling for Gemini provider by updating model support, handler logic, and conversion functions, with corresponding tests.

  • Behavior:
    • Enable native tool calling for Gemini models by setting supportsNativeTools: true in geminiModels in gemini.ts.
    • Update GeminiHandler in gemini.ts to handle tool-related metadata and function calls, including tool ID to name mapping and function call configuration.
  • Conversion Logic:
    • Update convertAnthropicContentToGemini() in gemini-format.ts to handle tool_use and tool_result blocks, using a map for tool ID to name conversion.
    • Add error handling for missing tool names in gemini-format.ts.
  • Tests:
    • Update tests in gemini-format.spec.ts to cover tool use and result conversion, including error cases for missing tool names.

This description was created by Ellipsis for b608e70. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025

Oroocle Clock   See task on Roo Cloud

Review complete for the latest Gemini native tool calling changes. No new issues were identified; previously flagged concerns remain resolved.

  • Tool call ID collision for Gemini native tool calling
  • Type mismatch in Gemini countTokens helper
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph force-pushed the feature/gemini-native-tools branch from d6bd20b to 88b3f74 Compare November 18, 2025 07:50
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 18, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025

Oroocle Clock   Follow along on Roo Cloud

Reviewing your PR now. Feedback coming soon!

@hannesrudolph hannesrudolph force-pushed the feature/gemini-native-tools branch from bb1973d to b4e50fb Compare November 19, 2025 04:12
@hannesrudolph hannesrudolph force-pushed the feature/gemini-native-tools branch from 935e817 to 7aa1152 Compare November 19, 2025 07:47
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 19, 2025
@hannesrudolph hannesrudolph force-pushed the feature/gemini-native-tools branch from de15baf to c8f7bf4 Compare November 19, 2025 15:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 19, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Nov 19, 2025
@mrubens mrubens merged commit e618d88 into main Nov 19, 2025
13 checks passed
@mrubens mrubens deleted the feature/gemini-native-tools branch November 19, 2025 21:14
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 19, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Nov 19, 2025
@alippai
Copy link

alippai commented Nov 20, 2025

@hannesrudolph does this detect Gemini over OpenAI compatible provider?

@hannesrudolph
Copy link
Collaborator Author

@hannesrudolph does this detect Gemini over OpenAI compatible provider?

Nope. It's running the genai ask

@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants