fix: filter out reasoning type messages in AnthropicVertexHandler #9584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnthropicVertexHandler was not filtering out reasoning type messages before sending them to the Vertex AI API, causing an error when the context filled up. This fix adds filtering similar to what GeminiHandler does, removing messages with type: "reasoning" which are not recognized by the Vertex AI API. Fixes #9583
dosubot
bot
added
size:L
Contributor
Author
Review complete. No issues found. The implementation correctly filters out reasoning-type messages before sending to the Vertex AI API, matching the proven pattern used in GeminiHandler. The test coverage is comprehensive and all changes follow existing code patterns. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
Contributor
Author
Review complete. No issues found. The implementation correctly filters out reasoning-type messages before sending to the Vertex AI API, matching the proven pattern used in GeminiHandler. The test coverage is comprehensive and all changes follow existing code patterns. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added a commit
that referenced
this pull request
Nov 26, 2025
Fixes context condensation error when using reasoning with Anthropic models on Vertex: 'Input tag reasoning found using type does not match any of the expected tags' The issue occurs because: 1. Roo Code stores reasoning content internally with type: 'reasoning' 2. Gemini stores thought signatures with type: 'thoughtSignature' 3. When messages are replayed to Anthropic/Vertex APIs, these non-standard types cause 400 errors Solution: - Added filterNonAnthropicBlocks() to anthropic-vertex.ts and anthropic.ts - Filters out 'reasoning' (internal Roo format) and 'thoughtSignature' (Gemini format) - Removes empty messages after filtering This follows the same pattern used by: - Gemini handler (filters 'reasoning' messages) - gemini-format.ts (skips unsupported block types) - Claude Code handler (filterMessagesForClaudeCode for images) Fixes #9583 Related to #9584
hannesrudolph
added a commit
that referenced
this pull request
Nov 26, 2025
Fixes context condensation error when using reasoning with Anthropic models on Vertex: 'Input tag reasoning found using type does not match any of the expected tags' The issue occurs because: 1. Roo Code stores reasoning content internally with type: 'reasoning' 2. Gemini stores thought signatures with type: 'thoughtSignature' 3. When messages are replayed to Anthropic/Vertex APIs, these non-standard types cause 400 errors Solution: - Added filterNonAnthropicBlocks() to anthropic-vertex.ts and anthropic.ts - Filters out 'reasoning' (internal Roo format) and 'thoughtSignature' (Gemini format) - Removes empty messages after filtering This follows the same pattern used by: - Gemini handler (filters 'reasoning' messages) - gemini-format.ts (skips unsupported block types) - Claude Code handler (filterMessagesForClaudeCode for images) Fixes #9583 Related to #9584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9583. Feedback and guidance are welcome.
Problem
Users were experiencing an error with Google Vertex AI when using Claude Sonnet models. The error message indicated that an input tag
reasoningwas being sent but is not recognized by the Vertex AI API. The valid tags are:document,image,redacted_thinking,search_result,text,thinking,tool_result,tool_use.Solution
The
AnthropicVertexHandlerwas not filtering outreasoningtype messages before sending them to the Vertex AI API. This fix adds filtering similar to whatGeminiHandlerdoes, removing messages withtype: "reasoning"which are not recognized by the Vertex AI API.Changes
AnthropicVertexHandler.createMessage()to removereasoningtype messagesTesting
npx vitest run src/api/providers/__tests__/anthropic-vertex.spec.tsFixes #9583
Important
Filters out
reasoningtype messages inAnthropicVertexHandlerto prevent Vertex AI API errors, with tests added to verify behavior.reasoningtype messages inAnthropicVertexHandler.createMessage()to prevent errors with Vertex AI API.anthropic-vertex.spec.tsto verifyreasoningmessages are filtered out.This description was created by
for 30304e2. You can customize this summary. It will automatically update as commits are pushed.