Skip to content

fix: OpenRouter GPT-5 strict schema validation for read_file tool #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 3 commits into from
Nov 27, 2025
Merged

fix: OpenRouter GPT-5 strict schema validation for read_file tool #9633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5e3a6c
fix: OpenRouter GPT-5 strict schema validation for read_file tool
daniel-lxs Nov 26, 2025
84ac365
fix: change browser_action strict mode to false and remove required a…
daniel-lxs Nov 27, 2025
433338d
fix: ensure 'action' is a required parameter for browser_action
daniel-lxs Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/prompts/tools/native-tools/browser_action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
function: {
name: "browser_action",
description: BROWSER_ACTION_DESCRIPTION,
strict: true,
strict: false,
parameters: {
type: "object",
properties: {
Expand Down
6 changes: 5 additions & 1 deletion src/core/prompts/tools/native-tools/read_file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ export function createReadFileTool(partialReadsEnabled: boolean = true): OpenAI.
}
}

// When using strict mode, ALL properties must be in the required array
// Optional properties are handled by having type: ["...", "null"]
const fileRequiredProperties = partialReadsEnabled ? ["path", "line_ranges"] : ["path"]

return {
type: "function",
function: {
Expand All @@ -70,7 +74,7 @@ export function createReadFileTool(partialReadsEnabled: boolean = true): OpenAI.
items: {
type: "object",
properties: fileProperties,
required: ["path"],
required: fileRequiredProperties,
additionalProperties: false,
},
minItems: 1,
Expand Down
Loading